Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP/1 doesn't need an executor #3108

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

bossmc
Copy link
Contributor

@bossmc bossmc commented Jan 4, 2023

HTTP/2 needs to spawn internal tasks in order to process each stream separately, but HTTP/1 does everything in one task and thus doesn't need access to an executor. This unused field seems to have been hidden from the linter because it was marked pub(super) so I've removed the same visibility marker on the server side's timer field.

This overlaps a little with #3017 since (at least for HTTP/1) there's no need to name the types of futures that need to be spawnable.

@seanmonstar seanmonstar merged commit 1de9acc into hyperium:master Jan 4, 2023
@bossmc bossmc deleted the http1-no-executor branch January 13, 2023 20:03
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 12, 2024
BREAKING CHANGE: The method
  `hyper::client::conn::http1::Builder::executor()` is removed, since it did nothing.
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 16, 2024
BREAKING CHANGE: The method
  `hyper::client::conn::http1::Builder::executor()` is removed, since it did nothing.

Signed-off-by: Sven Pfennig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants