feat(client): remove common::Exec::Default
#3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes `common::Exec::Default` that just panics when used. We are removing `tokio`, leaving `Exec::Default` with no implementation and panics when `Exec::execute` is called. Since `Exec::Default` has no purpose, it is being removed and user should now provide an implementation of executor. BREAKING CHANGE: remove `hyepr::common::Exec::Default` and refactor `hyper::client::conn::Http2::Builder::new`
seanmonstar
approved these changes
Jan 31, 2023
|
Excellent work, thank you so much! 🙏 |
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this pull request
Jan 12, 2024
This commit removes `common::Exec::Default` that just panics when used. We are removing `tokio`, leaving `Exec::Default` with no implementation and panics when `Exec::execute` is called. Since `Exec::Default` has no purpose, it is being removed and user should now provide an implementation of executor. Closes hyperium#3128 BREAKING CHANGE: `hyper::client::conn::Http2::Builder::new` now requires an executor argument.
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this pull request
Jan 16, 2024
This commit removes `common::Exec::Default` that just panics when used. We are removing `tokio`, leaving `Exec::Default` with no implementation and panics when `Exec::execute` is called. Since `Exec::Default` has no purpose, it is being removed and user should now provide an implementation of executor. Closes hyperium#3128 BREAKING CHANGE: `hyper::client::conn::Http2::Builder::new` now requires an executor argument. Signed-off-by: Sven Pfennig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3128
This PR removes
Exec::Defaultso that we avoid panicking by asking users to provide Executor right away.Exec::Defaultserves no purpose after #2975.Also refactors
hyper::client::conn::Http2::Builder::newas part of the removal.