Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump msrv to 1.60 #3250

Closed
wants to merge 4 commits into from
Closed

Bump msrv to 1.60 #3250

wants to merge 4 commits into from

Conversation

Ruben2424
Copy link
Contributor

CI fails in #3184 because the log crate now requires rustc version 1.60.

@seanmonstar
Copy link
Member

Do we need to bump it? Is log a dependency? Or just a dev-dependency?

@Ruben2424
Copy link
Contributor Author

i just ran cargo tree it is under the normal dependency tree under want and mio.

@seanmonstar
Copy link
Member

If we upgrade to want 0.3.1, it no longer depends on log. And by removing the default-features from mio, we'll be free!

@Ruben2424
Revert "Fix TODO comment"
ec956f5 
This reverts commit 841439c.
@Ruben2424
Revert "bump msrv"
f964011 
This reverts commit beb7659.
@Ruben2424
Copy link
Contributor Author

Ruben2424 commented Jun 15, 2023 •
edited
Loading

It looks like want 0.3.1 fixes the issue. No change needed.
Can you re-run CI in #3184

@Ruben2424 Ruben2424 closed this Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ruben2424 @seanmonstar