Add remove_raw method and corresponding test #331
Conversation
|
Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:
Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
|
Oh, I'm sorry I didn't read the guidelines. How can I undo this commit to fix the style? |
|
@filsmick: |
| @@ -206,6 +206,11 @@ impl Headers { | |||
| self.data.insert(UniCase(name.into_cow()), Item::new_raw(value)); | |||
| } | |||
|
|
|||
| /// Remove a header set by set_raw | |||
| pub fn remove_raw<K: IntoCow<'static, str>>(&mut self, name: K) { | |||
There was a problem hiding this comment.
Since the name isn't going to be stored, we can relax the requirement, just like with get_raw. We can accept any &str, not just static ones.
It was previously impossible to remove a header set by set_raw() Closes #326
|
I updated the message and relaxed the |
|
LGTM. |
Add remove_raw method and corresponding test
Closes #326