feat(http1): add option allowng leading whitespaces before first header #3643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This appears to be blocked on:
|
|
Yes. This PR is waiting for a new release of httparse to include the httparse changes you mentioned. |
|
There was an httpparse v1.9 release that you can refer to, now. |
seanmonstar
added
the
S-waiting-on-author
|
Do browsers actually parse the header, or do they ignore that header line just like they do for other kinds of invalid header lines? There was already an option to ignore invalid header lines in httparse, did it not make httparse silently ignore those initial headers with leading whitespace? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3285