Backport 0.14.x: feat(http1): support configurable max_headers #3773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanGoncharov
commented
Oct 23, 2024
| @@ -169,14 +170,17 @@ impl Http1Transaction for Server { | |||
| // but we *never* read any of it until after httparse has assigned | |||
| // values into it. By not zeroing out the stack memory, this saves | |||
| // a good ~5% on pipeline benchmarks. | |||
| let mut headers_indices: [MaybeUninit<HeaderIndices>; MAX_HEADERS] = unsafe { | |||
| // SAFETY: We can go safely from MaybeUninit array to array of MaybeUninit | |||
| MaybeUninit::uninit().assume_init() | |||
There was a problem hiding this comment.
I'm not sure if I should preserve unsafe and call assume_init
IvanGoncharov
commented
Oct 23, 2024
| // Unsafe: see comment in Server Http1Transaction, above. | ||
| let mut headers_indices: [MaybeUninit<HeaderIndices>; MAX_HEADERS] = unsafe { | ||
| // SAFETY: We can go safely from MaybeUninit array to array of MaybeUninit | ||
| MaybeUninit::uninit().assume_init() |
There was a problem hiding this comment.
I'm not sure if I should preserve unsafe and call assume_init
IvanGoncharov
commented
Oct 23, 2024
| client = [] | ||
| server = [] | ||
| client = ["dep:smallvec"] | ||
| server = ["dep:smallvec"] |
There was a problem hiding this comment.
I just ported it from #3523.
I'm not sure if it's required or not.
IvanGoncharov
force-pushed
the
backpor_header_size
branch
from
2c08250
to
c42aec7
Compare
|
As a general question / expectation-setting question about backports onto the 0.x line, is this PR following the repository's expectations around submitting backports? Are there other things you'd like to see done before considering this contribution? Additionally, is there a regular schedule for when backport releases would take place after PRs are reviewed and merged? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #3523 to
0.14.x.Context: At my work, we can't update to
1.x, but we need this change to fix the customer's issue.I backported #3523 and tried to resolve all conflicts.
Tests are passing, but I'm not sure about a few places.
I will mark this place with comments.