Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose set_nodelay for server and channel #119

Closed
LucioFranco opened this issue Nov 5, 2019 · 1 comment · Fixed by #145
Closed

Expose set_nodelay for server and channel #119

LucioFranco opened this issue Nov 5, 2019 · 1 comment · Fixed by #145
Labels
A-tonic C-enhancement Category: New feature or request E-easy Call for participation: Experience needed to fix: Easy / not much
Milestone
0.1

Comments

@LucioFranco
Copy link
Member

We should expose the hyper set_nodelay option as a config option for the transport channel and server.
@LucioFranco LucioFranco added C-enhancement Category: New feature or request E-easy Call for participation: Experience needed to fix: Easy / not much A-tonic labels Nov 5, 2019
@dominiquelefevre dominiquelefevre mentioned this issue Nov 6, 2019
Closed
@dominiquelefevre
Copy link
Contributor

dominiquelefevre commented Nov 6, 2019 •
edited
Loading

Hi,

I've made a PR #120 once I learned that my problem with abnormal latencies was caused by tokio defaulting to non-TCP_NODELAY sockets.

I did not make TCP_NODELAY a configuration option, though. It is required for services that exchange small requests, and adds no overhead in services that exchange bigger messages. I believe it makes sense to enable TCP_NODELAY unconditionally.

@alce alce mentioned this issue Nov 21, 2019
Merged
@LucioFranco LucioFranco added this to the 0.1 milestone Dec 6, 2019
brentalanmiller pushed a commit to brentalanmiller/tonic that referenced this issue Oct 6, 2023
@djc
tokio-rustls: initialize Acceptor with default() in tests (hyperium#119)
24473ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tonic C-enhancement Category: New feature or request E-easy Call for participation: Experience needed to fix: Easy / not much
Projects
None yet
Milestone
0.1
Development

Successfully merging a pull request may close this issue.

feat: expose tcp_nodelay for clients and servers alce/tonic
2 participants
@LucioFranco @dominiquelefevre