Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication example is doesn't work #678

Closed
Dentosal opened this issue Jun 10, 2021 · 1 comment · Fixed by #685
Closed

Authentication example is doesn't work #678

Dentosal opened this issue Jun 10, 2021 · 1 comment · Fixed by #685
Labels
C-bug Category: Something isn't working E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. I-crash Problems and improvements related to program crashes/panics.
Milestone

Comments

@Dentosal
Copy link

Bug Report

Version

Clean Tonic pulled from github master branch, at commit 4e0d2fc.

Platform

WSL 1 on WIndows 10. (4.4.0-19041-Microsoft #488-Microsoft x86_64 GNU/Linux)

Crates

Tonic itself, although I think it might be because Tower has changed.

Description

I tried

cd examples
 cargo run --bin authentication-client

And it crashes:

thread 'main' panicked at 'buffer full; poll_ready must be called first', /home/user/.cargo/registry/src/github.com-1ecc6299db9ec823/tower-0.4.8/src/buffer/service.rs:146:14
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
@davidpdrsn
Copy link
Member

Thanks for noticing!

I did some digging and this is most likely because we don't propagate backpressure here, which leads to the client pancking since it contains a tower::buffer::Buffer. The fix is the replace that line with self.inner.poll_ready(cx). I'll do that this week unless someone snatches it.

@davidpdrsn davidpdrsn added this to the 0.5 milestone Jun 10, 2021
@davidpdrsn davidpdrsn added C-bug Category: Something isn't working E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. I-crash Problems and improvements related to program crashes/panics. labels Jun 10, 2021
Szymongib added a commit to Szymongib/tonic that referenced this issue Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Something isn't working E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. I-crash Problems and improvements related to program crashes/panics.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants