Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tonic-web custom cors implementation and replace it with tower-http CorsLayer #1123

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

slinkydeveloper
Copy link
Contributor

Fix #1122, see the issue for more details.

This PR depends on #1119

@slinkydeveloper slinkydeveloper force-pushed the issues/1122 branch 3 times, most recently from 7ab10a3 to 5cefddf Compare October 25, 2022 10:06
@slinkydeveloper
Copy link
Contributor Author

I tested this branch on a personal project, connecting with connect-web client with grpc-web transport, and it works fine.

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me left a few comments

@LucioFranco LucioFranco mentioned this pull request Oct 28, 2022
@slinkydeveloper slinkydeveloper changed the title [WIP] Remove tonic-web custom cors implementation and replace it with tower-http CorsLayer Remove tonic-web custom cors implementation and replace it with tower-http CorsLayer Oct 31, 2022
@slinkydeveloper
Copy link
Contributor Author

For me this is ready now, it would be nice if someone else can test it though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup tonic-web cors support and replace it with tower-http
2 participants