Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make codegen independent from protoc #1953

Merged

Conversation

tottoto
Copy link
Collaborator

@tottoto tottoto commented Sep 23, 2024

Makes codegen independent from protoc by using protox. This eliminates the need to match protoc versions in development, and separates the public crates from protoc.

@tottoto tottoto force-pushed the make-codegen-independent-from-protoc branch 2 times, most recently from c27e9f6 to 5b46057 Compare September 23, 2024 02:52
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

codegen/src/main.rs Outdated Show resolved Hide resolved
@tottoto tottoto force-pushed the make-codegen-independent-from-protoc branch from 5b46057 to cb36543 Compare September 23, 2024 08:57
@tottoto tottoto force-pushed the make-codegen-independent-from-protoc branch from cb36543 to c0c19b1 Compare September 23, 2024 09:01
@tottoto tottoto added this pull request to the merge queue Sep 23, 2024
Merged via the queue into hyperium:master with commit 6d93c1d Sep 23, 2024
17 checks passed
@tottoto tottoto deleted the make-codegen-independent-from-protoc branch September 23, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants