Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transport): Emit HttpsUriWithoutTlsSupport only w/ tls feat #996

Merged
merged 1 commit into from
May 4, 2022

Conversation

guswynn
Copy link
Contributor

@guswynn guswynn commented May 3, 2022

Motivation

#838 breaks custom connectors that do tls in some other way (in my case, tokio-native-tls

Solution

Remove the error that was added in the other pr, if tls is not enabled

@guswynn guswynn marked this pull request as ready for review May 4, 2022 16:42
@guswynn guswynn changed the title add custom-tls feature to allow https: schemes with bring-your-own-connectors remove "tls not enabled" error when the tls feature is off May 4, 2022
@LucioFranco LucioFranco changed the title remove "tls not enabled" error when the tls feature is off fix(transport): Only emit HttpsUriWithoutTlsSupport when tls is enabled May 4, 2022
@LucioFranco LucioFranco changed the title fix(transport): Only emit HttpsUriWithoutTlsSupport when tls is enabled fix(transport): Emit HttpsUriWithoutTlsSupport only w/ tls feat May 4, 2022
@LucioFranco LucioFranco merged commit 1dd5ad2 into hyperium:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants