Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In kubectl hlf externalChainCode provide argument for selecting imagePullPolicy #142

Closed
JibinNajeeb opened this issue Feb 3, 2023 · 2 comments

Comments

@JibinNajeeb
Copy link

JibinNajeeb commented Feb 3, 2023

What would you like to be added?

In kubectl hlf externalChainCOde plugin the ImagePullPolicy is set as always. In my machine I don't have external access to repository.
It will be helpful if in imagePullPolicy different options are provided

func (c *createExternalChaincodeCmd) run() error {
	fabricChaincodeSpec := v1alpha1.FabricChaincodeSpec{
		Image:            c.image,
		ImagePullPolicy:  corev1.PullAlways, //I think this is the reason
		PackageID:        c.packageID,
		ImagePullSecrets: []corev1.LocalObjectReference{},
		Credentials:      nil,
		Replicas:         c.replicas,
	}
}

Why is this needed?

In kubectl hlf externalChainCOde plugin the ImagePullPolicy is set as always. In my machine I don't have direct external access to any public repository.

dviejokfs added a commit that referenced this issue Feb 18, 2023
@dviejokfs
Copy link
Contributor

Will be implemented in 1.9.0

@JibinNajeeb
Copy link
Author

Also consider for
peer create and ordnode create, Thanks

kubectl hlf peer create --image=$PEER_IMAGE --version=$PEER_VERSION --storage-class=standard --enroll-id=org1-peer1 --mspid=Org1MSP --enroll-pw=peerpw --capacity=5Gi --name=org1-peer1 --ca-name=org1-ca.fabric --namespace=fabric --statedb=couchdb --k8s-builder=true

kubectl hlf ordnode create --storage-class=standard --image=$ORDERER_IMAGE --version=$ORDERER_VERSION --enroll-id=orderer --mspid=OrdererMSP --enroll-pw=ordererpw --capacity=2Gi --name=ord-node1 --ca-name=ord-ca.fabric --namespace=fabric

dviejokfs added a commit that referenced this issue Apr 24, 2023
Signed-off-by: dviejokfs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants