Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cmd-socketio-server): rename package to match directory name #2105

Closed
petermetz opened this issue Jun 30, 2022 · 1 comment · Fixed by #2129
Closed

chore(cmd-socketio-server): rename package to match directory name #2105

petermetz opened this issue Jun 30, 2022 · 1 comment · Fixed by #2129
Labels
bug Something isn't working dependencies Pull requests that update a dependency file Developer_Experience documentation Improvements or additions to documentation

Comments

@petermetz
Copy link
Contributor

Describe the bug

The package is called cactus-cmd-socket-server while the directory is called cactus-cmd-socketio-server

To Reproduce

Look at the package and the directory names.

Expected behavior

Package and directory names match exactly. Package should be renamed to match the directory name.

cc: @outSH @izuru0 @takeutak
@petermetz petermetz added bug Something isn't working documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file Developer_Experience labels Jun 30, 2022
@outSH
Copy link
Contributor

outSH commented Jul 1, 2022

To Reproduce

Look at the package and the directory names.

❤️

outSH added a commit to outSH/cactus that referenced this issue Jul 22, 2022
@outSH
chore(cmd-socketio-server): rename package to match directory name
93811b3 
- Rename package name and all it's occurances to match directory name.

Closes hyperledger-cacti#2105

Signed-off-by: Michal Bajer <[email protected]>
@outSH outSH mentioned this issue Jul 22, 2022
Merged
petermetz pushed a commit to outSH/cactus that referenced this issue Aug 24, 2022
@outSH @petermetz
chore(cmd-socketio-server): rename package to match directory name
2cdd16b 
- Rename package name and all it's occurances to match directory name.

Closes hyperledger-cacti#2105

Signed-off-by: Michal Bajer <[email protected]>
petermetz pushed a commit that referenced this issue Aug 25, 2022
@outSH @petermetz
chore(cmd-socketio-server): rename package to match directory name
a776a60 
- Rename package name and all it's occurances to match directory name.

Closes #2105

Signed-off-by: Michal Bajer <[email protected]>
@outSH outSH mentioned this issue Sep 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file Developer_Experience documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(cmd-socketio-server): rename package to match directory name outSH/cactus
2 participants
@petermetz @outSH