Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(connector-fabric): fix v2-2-x/deploy-lock-asset.test.ts #2341

Closed
petermetz opened this issue Mar 24, 2023 · 0 comments · Fixed by #2342
Closed

test(connector-fabric): fix v2-2-x/deploy-lock-asset.test.ts #2341

petermetz opened this issue Mar 24, 2023 · 0 comments · Fixed by #2342
Assignees
@petermetz
Labels
bug Something isn't working Fabric Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) good-first-issue Good for newcomers good-first-issue-300-advanced Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P2 Priority 2: High Tests Anything related to tests be that automatic or manual, integration or unit, etc.

Comments

@petermetz
Copy link
Contributor

The exact same issue as it was with https://github.com/hyperledger/cacti/issues/2322
but this time it's in the source code of another test fixture (which is also a chain code written in Typescript).

Logs/Stack traces

2023-03-24T05-33-31_cacti_connector_fabric_test_crash.log
@petermetz petermetz added bug Something isn't working good-first-issue Good for newcomers Fabric Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. good-first-issue-300-advanced Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) Tests Anything related to tests be that automatic or manual, integration or unit, etc. P2 Priority 2: High labels Mar 24, 2023
@petermetz petermetz self-assigned this Mar 24, 2023
@petermetz petermetz changed the title test(connector-fabric): fix chaincode compilation error test(connector-fabric): fix v2-2-x/deploy-lock-asset.test.ts Mar 24, 2023
petermetz added a commit to petermetz/cacti that referenced this issue Mar 24, 2023
@petermetz
test(connector-fabric): fix v2-2-x/deploy-lock-asset.test.ts
4d70486 
Telling the typescript compiler to skip the library code check so that
auto-updating dependencies don't break the test fixture chain code
compilation.

The root cause and the fix are equivalent as they were for:
https://github.com/hyperledger/cacti/issues/2322
https://github.com/hyperledger/cacti/pull/2323
Commit SHA: dfb7278

Fixes hyperledger-cacti#2341

Also sneaking in a .gitignore change with this: there is a VSCode
extension that stores local editing history of files in a .history/
sub-folder and that needs to be ignored in git otherwise it just keeps
popping up in the git index which is annoying sometimes.

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz mentioned this issue Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
bug Something isn't working Fabric Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) good-first-issue Good for newcomers good-first-issue-300-advanced Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P2 Priority 2: High Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(connector-fabric): fix v2-2-x/deploy-lock-asset.test.ts petermetz/cacti
1 participant
@petermetz