Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(besu): deployContractSolBytecodeNoKeychainV1 requires keychainId #3586

Closed
petermetz opened this issue Oct 14, 2024 · 0 comments · Fixed by #3587
Closed

fix(besu): deployContractSolBytecodeNoKeychainV1 requires keychainId #3586

petermetz opened this issue Oct 14, 2024 · 0 comments · Fixed by #3587
Assignees
@petermetz
Labels
Besu bug Something isn't working P1 Priority 1: Highest
Milestone
v2.0.0

Comments

@petermetz
Copy link
Contributor

Description

In the DeployContractSolidityBytecodeNoKeychainV1Request of packages/cactus-plugin-ledger-connector-besu/src/main/json/openapi.tpl.json there are parameters that are required despite the entire point of this operation is to not need them (e.g. keychainId and contract JSON object).

Acceptance Criteria

  1. The OpenAPI specs for the endpoints are refactored so that only the really needed parameters are declared as required
  2. Build and tests are still passing after the change.
@petermetz petermetz added bug Something isn't working Besu P1 Priority 1: Highest labels Oct 14, 2024
@petermetz petermetz added this to the v2.0.0 milestone Oct 14, 2024
@petermetz petermetz self-assigned this Oct 14, 2024
petermetz added a commit to petermetz/cacti that referenced this issue Oct 14, 2024
@petermetz
fix(besu): deployContractSolBytecodeNoKeychainV1 requires keychainId
512a783 
In the DeployContractSolidityBytecodeNoKeychainV1Request of
`packages/cactus-plugin-ledger-connector-besu/src/main/json/openapi.tpl.json`
there are parameters that are required despite the entire point of this
operation is to not need them (e.g. keychainId and contract JSON object).

Fixes hyperledger-cacti#3586

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz mentioned this issue Oct 14, 2024
Merged
5 tasks
brunoffmateus pushed a commit to brunoffmateus/blockchain-integration-framework that referenced this issue Oct 15, 2024
@petermetz @brunoffmateus
fix(besu): deployContractSolBytecodeNoKeychainV1 requires keychainId
5f9c291 
In the DeployContractSolidityBytecodeNoKeychainV1Request of
`packages/cactus-plugin-ledger-connector-besu/src/main/json/openapi.tpl.json`
there are parameters that are required despite the entire point of this
operation is to not need them (e.g. keychainId and contract JSON object).

Fixes hyperledger-cacti#3586

Signed-off-by: Peter Somogyvari <[email protected]>
petermetz added a commit to petermetz/cacti that referenced this issue Oct 17, 2024
@petermetz
fix(besu): deployContractSolBytecodeNoKeychainV1 requires keychainId
d71e316 
In the DeployContractSolidityBytecodeNoKeychainV1Request of
`packages/cactus-plugin-ledger-connector-besu/src/main/json/openapi.tpl.json`
there are parameters that are required despite the entire point of this
operation is to not need them (e.g. keychainId and contract JSON object).

Fixes hyperledger-cacti#3586

Signed-off-by: Peter Somogyvari <[email protected]>
brunoffmateus added a commit to brunoffmateus/blockchain-integration-framework that referenced this issue Oct 18, 2024
@brunoffmateus
feat(satp-hermes): gateway runner and docker for SATP
4d178a4 
Signed-off-by: Bruno Mateus <[email protected]>

refactor(satp-hermes): gateway container image definition with bundler

Signed-off-by: Peter Somogyvari <[email protected]>

refactor(satp-hermes): merge policies type guard example

Signed-off-by: Peter Somogyvari <[email protected]>

refactor(satp-hermes): type guards for SATP env variables

Signed-off-by: Bruno Mateus <[email protected]>

squash! - peter's fixes for besu connectivity use LAN IP

Instead of hardcoded localhost use the LAN IP of machine so that the
gateway container can access it too.

Why though? Because if you tell the gateway container that it should
access the besu ledger via localhost then it will try to do that through
the container's own localhost, which is different from the host machine's
localhost (where the besu ledger is actually running).

Using the actual IP address of the host machine's primary network interface
resolves the ambiguity between the two differnet localhosts.

Signed-off-by: Peter Somogyvari <[email protected]>

fix(besu): deployContractSolBytecodeNoKeychainV1 requires keychainId

In the DeployContractSolidityBytecodeNoKeychainV1Request of
`packages/cactus-plugin-ledger-connector-besu/src/main/json/openapi.tpl.json`
there are parameters that are required despite the entire point of this
operation is to not need them (e.g. keychainId and contract JSON object).

Fixes hyperledger-cacti#3586

Signed-off-by: Peter Somogyvari <[email protected]>
brunoffmateus added a commit to brunoffmateus/blockchain-integration-framework that referenced this issue Oct 18, 2024
@brunoffmateus
feat(satp-hermes): gateway runner and docker for SATP
498ec34 
Signed-off-by: Bruno Mateus <[email protected]>

refactor(satp-hermes): gateway container image definition with bundler

Signed-off-by: Peter Somogyvari <[email protected]>

refactor(satp-hermes): merge policies type guard example

Signed-off-by: Peter Somogyvari <[email protected]>

refactor(satp-hermes): type guards for SATP env variables

Signed-off-by: Bruno Mateus <[email protected]>

squash! - peter's fixes for besu connectivity use LAN IP

Instead of hardcoded localhost use the LAN IP of machine so that the
gateway container can access it too.

Why though? Because if you tell the gateway container that it should
access the besu ledger via localhost then it will try to do that through
the container's own localhost, which is different from the host machine's
localhost (where the besu ledger is actually running).

Using the actual IP address of the host machine's primary network interface
resolves the ambiguity between the two differnet localhosts.

Signed-off-by: Peter Somogyvari <[email protected]>

fix(besu): deployContractSolBytecodeNoKeychainV1 requires keychainId

In the DeployContractSolidityBytecodeNoKeychainV1Request of
`packages/cactus-plugin-ledger-connector-besu/src/main/json/openapi.tpl.json`
there are parameters that are required despite the entire point of this
operation is to not need them (e.g. keychainId and contract JSON object).

Fixes hyperledger-cacti#3586

Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
Besu bug Something isn't working P1 Priority 1: Highest
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

fix(besu): deployContractSolBytecodeNoKeychainV1 requires keychainId petermetz/cacti
1 participant
@petermetz