Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): publish v1.1.0 #2173

Merged
merged 1 commit into from
Oct 19, 2022
Merged

chore(release): publish v1.1.0 #2173

merged 1 commit into from
Oct 19, 2022

Conversation

petermetz
Copy link
Contributor

Also manually changing the "publishConfig" property of the
packages/cactus-cmd-socketio-server/package.json
file because it was not set to public which excluded it from the
release automation altogether in previous releases, causing this bug
to be reported:
#2069

Fixes #2069

Signed-off-by: Peter Somogyvari [email protected]

Also manually changing the "publishConfig" property of the
packages/cactus-cmd-socketio-server/package.json
file because it was not set to public which excluded it from the
release automation altogether in previous releases, causing this bug
to be reported:
#2069

Fixes #2069

Signed-off-by: Peter Somogyvari <[email protected]>
@jagpreetsinghsasan
Copy link
Contributor

@petermetz should we also mention how we can skip the Indy SDK blocker (if someone have) by simply removing the indy-sdk dependency under examples/cactus-example-discounted-asset-trade/package.json (so that we can build the project in case of this blocker)?

@petermetz
Copy link
Contributor Author

@petermetz should we also mention how we can skip the Indy SDK blocker (if someone have) by simply removing the indy-sdk dependency under examples/cactus-example-discounted-asset-trade/package.json (so that we can build the project in case of this blocker)?

@jagpreetsinghsasan Yes. But in my opinion, that should be explained in the relevant parts of the documentation in general (BUILD.md/CONTRIBUTING.md) not just specifically for this release. So I agree that we need to have that information available. It should also be clarified under what circumstances it does not work (I kept myself on Ubuntu 20.04 and still have not seen the issue at all so there's some nuance to it)

@petermetz petermetz merged commit cc8deb8 into main Oct 19, 2022
@petermetz petermetz deleted the release-v1.1.0 branch October 19, 2022 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(release): missing @hyperledger/cactus-cmd-socket-server npm package
3 participants