chore(release): publish v1.1.1 #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan and
sandeepnRES
as code owners
jagpreetsinghsasan
approved these changes
Nov 3, 2022
takeutak
approved these changes
Nov 3, 2022
petermetz
force-pushed
the
release-v1.1.1
branch
from
a7fc04e
to
86847ae
Compare
This is needed because of the botched (congrats Peter) v1.1.0 release which we attempted to fix by adding a new workflow action that gets triggered on tags and then re-applying (delete+re-tag) the v1.1.0 release tag. Only after all this was it discovered that the workflow action meant to push the 1.1.0 npm artifacts will not get triggered on the v1.1.0 tag because the workflow file got added in a commit prior to v1.1.0 so the only way to fix it would be to: have direct push access ot npm once again (temporarily) until we can issue the 1.1.0 release or re-write the git history of the upstream main branch (a big no-no unless we absolutely must do that for whatever reason) TLDR: Issuing a v1.1.1 release here basically just to test whether the auto-publishing of packages with the new workflow works at all or not. If it has bugs or does not work for whatever other reason we will need to itreate on the workflow file and then issue a v1.1.2 and more of those as needed until we figure out the auto-publishing so that it "just works" Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
force-pushed
the
release-v1.1.1
branch
from
86847ae
to
e7aa865
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed because of the botched (congrats Peter) v1.1.0 release which we attempted to fix by adding a new workflow action that gets triggered on tags and then re-applying (delete+re-tag) the v1.1.0 release tag.
Only after all this was it discovered that the workflow action meant to push the 1.1.0 npm artifacts will not get triggered on the v1.1.0 tag because the workflow file got added in a commit prior to v1.1.0 so the only way to fix it would be to:
TLDR: Issuing a v1.1.1 release here basically just to test whether the auto-publishing of packages with the new workflow works at all or not. If it has bugs or does not work for whatever other reason we will need to itreate on the workflow file and then issue a v1.1.2 and more of those as needed until we figure out the auto-publishing so that it "just works"
Signed-off-by: Peter Somogyvari [email protected]