fix(test-tooling): substrate test ledger fails if WS_PORT not specified #2222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker expects environment variables passed to the container to be strings. The null coalescing code was making it so that if the test case did not pass in a custom WS_PORT env var, then it would default to using a value for the port that was a number not a string. This would crash the serialization logic within docker that was trying to apply the environment variables to the container when starting it. Switching the type of 9944 default WS port to "9944" (string) fixes it. Also specifying explicitly the `wsPort` variable's type to be string so that the next time someone tries to make this mistake the compiler will slap their hands right away. Fixes hyperledger-cacti#2213 Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan and
sandeepnRES
as code owners
jagpreetsinghsasan
approved these changes
Nov 30, 2022
takeutak
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker expects environment variables passed to the container
to be strings.
The null coalescing code was making it so that if the test case
did not pass in a custom WS_PORT env var, then it would default
to using a value for the port that was a number not a string.
This would crash the serialization logic within docker that was
trying to apply the environment variables to the container when
starting it.
Switching the type of 9944 default WS port to "9944" (string) fixes it.
Also specifying explicitly the
wsPortvariable's type to bestring so that the next time someone tries to make this mistake
the compiler will slap their hands right away.
Fixes #2213
Signed-off-by: Peter Somogyvari [email protected]