feat(relay): configurable db_open retry mechanism added and in driver #2384
Conversation
sandeepnRES
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan and
VRamakrishna
as code owners
|
@sandeepnRES Add a bit more description to your initial comment: Go version upgrades, need for the retry logic (to manage concurrent accesses to a LevelDB instance so that protocols don't fail because of temporary resource contention.) |
There was a problem hiding this comment.
@sandeepnRES On top of what Rama said I also highly recommend having a message body for your commit instead of just adding the details to the GitHub PR description.
The PR description is stored in the private databases of GitHub, the commit message body is stored in the git commit log which is public (so they are very different from each other even though the GUI of GitHub makes them feel like the same thing).
sandeepnRES
force-pushed
the
main
branch
2 times, most recently
from
f98c6bd
to
ec5ccc4
Compare
|
Hi @petermetz I've modified the the PR description as per Rama's comments, and also added same in commit message. But it seems PR is blocked because your have marked as |
To manage concurrent accesses to a LevelDB instance so that protocols
don't fail because of temporary resource contention, added two env
variables in driver and config variables in relay to configure retry
mechanism while opening database:
- Max number of retries
- Backoff time in milli seconds.
Additionally upgraded go versions to v1.20 in publish workflows.
Signed-off-by: Sandeep Nishad <[email protected]>
To manage concurrent accesses to a LevelDB instance so that protocols
don't fail because of temporary resource contention, added two env
variables in driver and config variables in relay to configure retry
mechanism while opening database:
Additionally upgraded go versions to v1.20 in publish workflows.