Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): try new builers #2391

Merged
merged 1 commit into from
Apr 18, 2023
Merged

chore(ci): try new builers #2391

merged 1 commit into from
Apr 18, 2023

Conversation

ryjones
Copy link
Contributor

@ryjones ryjones commented Apr 13, 2023 •
edited
Loading

rename yaml->yml

update actions versions

Signed-off-by: Ry Jones [email protected]

@ryjones ryjones force-pushed the CICD branch 2 times, most recently from 8860a6f to 2370e6a Compare April 13, 2023 15:02
petermetz
petermetz approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryjones Thank you, LGTM!

@ryjones ryjones force-pushed the CICD branch 4 times, most recently from 3f73d75 to fe901b5 Compare April 13, 2023 17:17
petermetz
petermetz requested changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryjones There are still some leftover yaml -> yml renames that need to be removed from the diff. I just checked out why the CodeQL is failing and it's also because of that (it only looks for it's own config file with .yml but not with .yaml)

Edit: Oh wait, now I'm confused/turned around. Just realized you did revert the renames, but then maybe there are now renames but in the other direction (which I'm OK with except in the cases where tooling we can't control/configure this extent mandates whichever extension - then we have no choice but to go with) so maybe all it needs is just changing that one config file back to .yml (the one from the screenshot)

Screenshot from 2023-04-14 00-33-18

Screenshot from 2023-04-14 00-33-04

@ryjones ryjones force-pushed the CICD branch 2 times, most recently from da99ce6 to a501f06 Compare April 14, 2023 17:26
@ryjones
Copy link
Contributor Author

ryjones commented Apr 14, 2023

@petermetz I renamed that one file back to .yml

jagpreetsinghsasan
jagpreetsinghsasan approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandeepnRES
Copy link
Contributor

sandeepnRES commented Apr 17, 2023 •
edited
Loading

Hi @ryjones I think you missed updating runner for .github/workflows/test_weaver-data-sharing.yaml, because the runner that used there was buildjet-4vcpu-ubuntu-2204 (probably missed from find and replace). I don't know if this was intentional, hence asking you here.

@ryjones
Copy link
Contributor Author

ryjones commented Apr 17, 2023

@sandeepnRES oversight on my part.

@ryjones ryjones requested a review from petermetz April 17, 2023 16:21
petermetz
petermetz approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryjones LGTM, thank you!

@ryjones
chore(ci): try new builers
342ade7 
rename yml->yaml

except codeql

update actions

Signed-off-by: Ry Jones <[email protected]>
@petermetz petermetz merged commit a4cf391 into main Apr 18, 2023
@petermetz petermetz deleted the CICD branch April 18, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petermetz petermetz petermetz approved these changes

@jagpreetsinghsasan jagpreetsinghsasan jagpreetsinghsasan approved these changes

@takeutak takeutak takeutak approved these changes

@izuru0 izuru0 Awaiting requested review from izuru0 izuru0 is a code owner

@VRamakrishna VRamakrishna Awaiting requested review from VRamakrishna VRamakrishna is a code owner

@sandeepnRES sandeepnRES Awaiting requested review from sandeepnRES sandeepnRES is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ryjones @sandeepnRES @petermetz @jagpreetsinghsasan @takeutak