-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openssl): version upgrade to v0.10.48 in cactus-plugin-keychain-vault #2403
Conversation
…tements in cactus-plugin-keychain-vault package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Poonam1607 thankyou for the PR
As far I can see in the changed files, there is no change of parenthesis anywhere.
So I am updating the PR title.
For the PR description and the commit message, please refer to our contribution guide.
You can also refer to one of my merged PR's for reference: https://github.com/hyperledger/cacti/pull/2272
Thankyou @jagpreetsinghsasan for doing that! Also, is there anything else wrong with the commit? Some checks are failing, can you please review it? |
@Poonam1607 the previous review comments I provided are still not fixed. |
Signed-off-by: Poonam1607 <[email protected]>
@Poonam1607 Hi, Thank you for the PR, but there are few issues with PR, so it can't be merged yet. I am updating the title again just to make it more unique. Also squashing the commit is not possible, as there are some conflicts, so you will have to create same changes again in fresh branch/fork that is in sync with main. Make sure there are no |
I did the changes with a new PR - feat(openssl): version upgrade to v0.10.48 in cactus-plugin-keychain-vault #2412 |
…tements in cactus-plugin-keychain-vault package