ci(custom-checks): fix sibling pkg dependency version inconsistencies #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwat17
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
takeutak
approved these changes
Jun 15, 2023
sandeepnRES
approved these changes
Jun 15, 2023
petermetz
changed the title
I also snuck in a couple of additional changes in the interest of speeding up CI execution as soon as possible. Apologies for the intrusion! - Peter Somogyvari The additional changes are: 1. Comment out (e.g. disable) the odap-hermes plugin's tests for now since they are completely broken anyway and just wasting CI resources. 2. Fixed a logging bug in the custom-checks .ts script 3. Modified the ci.sh file (the workhorse of the CI) so that it does run the custom-checks as part of it. This was made possible by the change that this commit is originally intended to do (e.g., without this change the custom checks would fail but now they pass) Closes: hyperledger-cacti#2431 Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]> Signed-off-by: Tomasz Awramski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2431