fix(indy-validator): fix package dependencies #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
outSH
force-pushed
the
fix_example_apps_pr
branch
from
861d3e1
to
0f3e7e9
Compare
Done |
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Aug 29, 2023
…ne) signatures
- Add new `RunDelegatedSignTransactionEndpointV1` endpoint for delegated / offline signing.
Takes `signerCertificate` and `signerMspID`, uses `signCallback` on connector to sign messages.
Sign must be implemented by a user, can contain any logic
(contacting 3'rd party services, reading from secure sources, etc…).
Interface is similar to transact. Supports private transactions.
- Refactor transact endpoint: Use common logic for handling response format. with delegated transact
- Refactor logic of choosing ednorsers in transact endpoint. Previously both `endorsingPeers`
and `endorsingParties` were selecting organizations in sligly different way under different
circumstances. Now `endorsingPeers` selectes peers and `endorsingOrgs` selects orgs for all
cases (query, send, privatesend) in both transact and transact with delegated sign.
This is more consistent and predictable.
- Add new socketio endpoint `SubscribeDelegatedSign` for monitoring new blocks with delegated sign.
- Use common error handling in getblock, transact and transact delgated endpoints.
- Add functional tests for delegated signing feature.
Depends on: hyperledger-cacti#2598
Signed-off-by: Michal Bajer <[email protected]>
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Aug 29, 2023
…ne) signatures
- Add new `RunDelegatedSignTransactionEndpointV1` endpoint for delegated / offline signing.
Takes `signerCertificate` and `signerMspID`, uses `signCallback` on connector to sign messages.
Sign must be implemented by a user, can contain any logic
(contacting 3'rd party services, reading from secure sources, etc…).
Interface is similar to transact. Supports private transactions.
- Refactor transact endpoint: Use common logic for handling response format. with delegated transact
- Refactor logic of choosing ednorsers in transact endpoint. Previously both `endorsingPeers`
and `endorsingParties` were selecting organizations in sligly different way under different
circumstances. Now `endorsingPeers` selectes peers and `endorsingOrgs` selects orgs for all
cases (query, send, privatesend) in both transact and transact with delegated sign.
This is more consistent and predictable.
- Add new socketio endpoint `SubscribeDelegatedSign` for monitoring new blocks with delegated sign.
- Use common error handling in getblock, transact and transact delgated endpoints.
- Add functional tests for delegated signing feature.
Depends on: hyperledger-cacti#2598
Signed-off-by: Michal Bajer <[email protected]>
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Aug 29, 2023
…ne) signatures
- Add new `RunDelegatedSignTransactionEndpointV1` endpoint for delegated / offline signing.
Takes `signerCertificate` and `signerMspID`, uses `signCallback` on connector to sign messages.
Sign must be implemented by a user, can contain any logic
(contacting 3'rd party services, reading from secure sources, etc…).
Interface is similar to transact. Supports private transactions.
- Refactor transact endpoint: Use common logic for handling response format. with delegated transact
- Refactor logic of choosing ednorsers in transact endpoint. Previously both `endorsingPeers`
and `endorsingParties` were selecting organizations in sligly different way under different
circumstances. Now `endorsingPeers` selectes peers and `endorsingOrgs` selects orgs for all
cases (query, send, privatesend) in both transact and transact with delegated sign.
This is more consistent and predictable.
- Add new socketio endpoint `SubscribeDelegatedSign` for monitoring new blocks with delegated sign.
- Use common error handling in getblock, transact and transact delgated endpoints.
- Add functional tests for delegated signing feature.
Depends on: hyperledger-cacti#2598
Signed-off-by: Michal Bajer <[email protected]>
petermetz
reviewed
Aug 29, 2023
petermetz
requested changes
Aug 29, 2023
There was a problem hiding this comment.
@outSH I just spotted that the parent PR's commit is still in here with a few lines of diff, but the parent PR has already been merged onto main so please squash or remove the second commit otherwise when we merge this there'll be two commits with the same message but one of them will have the actual diff while the other just a couple of these lines of changes.
outSH
force-pushed
the
fix_example_apps_pr
branch
2 times, most recently
from
913c086
to
76cac34
Compare
@petermetz You're right, sorry for that. Fixed, rebased and ready for merge |
- Update indy validator python dependencies. - Add README chapter on updating python dependencies to simplify this process in the future. - Use pinend ubuntu base image in indy-sdk-cli dockerfile. - Do some minor README improvements and cleanups. - Use pinned fabric-all-in-one versions in discounted-asset-trade. Tested with `discounted-asset-trade` (should work without an issue now, at least dockerless one) Depends on: hyperledger-cacti#2596 Signed-off-by: Michal Bajer <[email protected]>
petermetz
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
@petermetz You're right, sorry for that. Fixed, rebased and ready for merge
@outSH No worries, thank you very much for the updates! LGTM
petermetz
force-pushed
the
fix_example_apps_pr
branch
from
76cac34
to
a28641a
Compare
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Sep 18, 2023
…ne) signatures
- Add new `RunDelegatedSignTransactionEndpointV1` endpoint for delegated / offline signing.
Takes `signerCertificate` and `signerMspID`, uses `signCallback` on connector to sign messages.
Sign must be implemented by a user, can contain any logic
(contacting 3'rd party services, reading from secure sources, etc…).
Interface is similar to transact. Supports private transactions.
- Refactor transact endpoint: Use common logic for handling response format. with delegated transact
- Refactor logic of choosing ednorsers in transact endpoint. Previously both `endorsingPeers`
and `endorsingParties` were selecting organizations in sligly different way under different
circumstances. Now `endorsingPeers` selectes peers and `endorsingOrgs` selects orgs for all
cases (query, send, privatesend) in both transact and transact with delegated sign.
This is more consistent and predictable.
- Add new socketio endpoint `SubscribeDelegatedSign` for monitoring new blocks with delegated sign.
- Use common error handling in getblock, transact and transact delgated endpoints.
- Add functional tests for delegated signing feature.
Depends on: hyperledger-cacti#2598
Signed-off-by: Michal Bajer <[email protected]>
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Sep 28, 2023
…ne) signatures
- Add new `RunDelegatedSignTransactionEndpointV1` endpoint for delegated / offline signing.
Takes `signerCertificate` and `signerMspID`, uses `signCallback` on connector to sign messages.
Sign must be implemented by a user, can contain any logic
(contacting 3'rd party services, reading from secure sources, etc…).
Interface is similar to transact. Supports private transactions.
- Refactor transact endpoint: Use common logic for handling response format. with delegated transact
- Refactor logic of choosing ednorsers in transact endpoint. Previously both `endorsingPeers`
and `endorsingParties` were selecting organizations in sligly different way under different
circumstances. Now `endorsingPeers` selectes peers and `endorsingOrgs` selects orgs for all
cases (query, send, privatesend) in both transact and transact with delegated sign.
This is more consistent and predictable.
- Add new socketio endpoint `SubscribeDelegatedSign` for monitoring new blocks with delegated sign.
- Use common error handling in getblock, transact and transact delgated endpoints.
- Add functional tests for delegated signing feature.
Depends on: hyperledger-cacti#2598
Signed-off-by: Michal Bajer <[email protected]>
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Oct 2, 2023
…ne) signatures
- Add new `RunDelegatedSignTransactionEndpointV1` endpoint for delegated / offline signing.
Takes `signerCertificate` and `signerMspID`, uses `signCallback` on connector to sign messages.
Sign must be implemented by a user, can contain any logic
(contacting 3'rd party services, reading from secure sources, etc…).
Interface is similar to transact. Supports private transactions.
- Refactor transact endpoint: Use common logic for handling response format. with delegated transact
- Refactor logic of choosing ednorsers in transact endpoint. Previously both `endorsingPeers`
and `endorsingParties` were selecting organizations in sligly different way under different
circumstances. Now `endorsingPeers` selectes peers and `endorsingOrgs` selects orgs for all
cases (query, send, privatesend) in both transact and transact with delegated sign.
This is more consistent and predictable.
- Add new socketio endpoint `SubscribeDelegatedSign` for monitoring new blocks with delegated sign.
- Use common error handling in getblock, transact and transact delgated endpoints.
- Add functional tests for delegated signing feature.
Depends on: hyperledger-cacti#2598
Signed-off-by: Michal Bajer <[email protected]>
petermetz
pushed a commit
to outSH/cactus
that referenced
this pull request
Oct 10, 2023
…ne) signatures
- Add new `RunDelegatedSignTransactionEndpointV1` endpoint for delegated / offline signing.
Takes `signerCertificate` and `signerMspID`, uses `signCallback` on connector to sign messages.
Sign must be implemented by a user, can contain any logic
(contacting 3'rd party services, reading from secure sources, etc…).
Interface is similar to transact. Supports private transactions.
- Refactor transact endpoint: Use common logic for handling response format. with delegated transact
- Refactor logic of choosing ednorsers in transact endpoint. Previously both `endorsingPeers`
and `endorsingParties` were selecting organizations in sligly different way under different
circumstances. Now `endorsingPeers` selectes peers and `endorsingOrgs` selects orgs for all
cases (query, send, privatesend) in both transact and transact with delegated sign.
This is more consistent and predictable.
- Add new socketio endpoint `SubscribeDelegatedSign` for monitoring new blocks with delegated sign.
- Use common error handling in getblock, transact and transact delgated endpoints.
- Add functional tests for delegated signing feature.
Depends on: hyperledger-cacti#2598
Signed-off-by: Michal Bajer <[email protected]>
petermetz
pushed a commit
that referenced
this pull request
Oct 10, 2023
…ne) signatures
- Add new `RunDelegatedSignTransactionEndpointV1` endpoint for delegated / offline signing.
Takes `signerCertificate` and `signerMspID`, uses `signCallback` on connector to sign messages.
Sign must be implemented by a user, can contain any logic
(contacting 3'rd party services, reading from secure sources, etc…).
Interface is similar to transact. Supports private transactions.
- Refactor transact endpoint: Use common logic for handling response format. with delegated transact
- Refactor logic of choosing ednorsers in transact endpoint. Previously both `endorsingPeers`
and `endorsingParties` were selecting organizations in sligly different way under different
circumstances. Now `endorsingPeers` selectes peers and `endorsingOrgs` selects orgs for all
cases (query, send, privatesend) in both transact and transact with delegated sign.
This is more consistent and predictable.
- Add new socketio endpoint `SubscribeDelegatedSign` for monitoring new blocks with delegated sign.
- Use common error handling in getblock, transact and transact delgated endpoints.
- Add functional tests for delegated signing feature.
Depends on: #2598
Signed-off-by: Michal Bajer <[email protected]>
sandeepnRES
pushed a commit
to sandeepnRES/cacti
that referenced
this pull request
Dec 21, 2023
…ne) signatures
- Add new `RunDelegatedSignTransactionEndpointV1` endpoint for delegated / offline signing.
Takes `signerCertificate` and `signerMspID`, uses `signCallback` on connector to sign messages.
Sign must be implemented by a user, can contain any logic
(contacting 3'rd party services, reading from secure sources, etc…).
Interface is similar to transact. Supports private transactions.
- Refactor transact endpoint: Use common logic for handling response format. with delegated transact
- Refactor logic of choosing ednorsers in transact endpoint. Previously both `endorsingPeers`
and `endorsingParties` were selecting organizations in sligly different way under different
circumstances. Now `endorsingPeers` selectes peers and `endorsingOrgs` selects orgs for all
cases (query, send, privatesend) in both transact and transact with delegated sign.
This is more consistent and predictable.
- Add new socketio endpoint `SubscribeDelegatedSign` for monitoring new blocks with delegated sign.
- Use common error handling in getblock, transact and transact delgated endpoints.
- Add functional tests for delegated signing feature.
Depends on: hyperledger-cacti#2598
Signed-off-by: Michal Bajer <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with
discounted-asset-trade(should work without an issue now, at least dockerless one)Depends on: #2596
Signed-off-by: Michal Bajer [email protected]