Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cactus-plugin-ledger-connector-iroha): remove deprecated connector #3160

Merged
merged 1 commit into from
Apr 1, 2024
Merged

feat(cactus-plugin-ledger-connector-iroha): remove deprecated connector #3160

merged 1 commit into from
Apr 1, 2024

Conversation

outSH
Copy link
Contributor

@outSH outSH commented Mar 29, 2024 •
edited
Loading

  • Iroha connector is broken for some time and it's SDK does't seem to be actively supported anymore (in regards of bug or security fixes).

Closes: #3159
Part of: #3155

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

izuru0
izuru0 approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jagpreetsinghsasan
jagpreetsinghsasan reviewed Apr 1, 2024
View reviewed changes
Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@outSH @petermetz
feat(cactus-plugin-ledger-connector-iroha): remove deprecated iroha c…
c4a4052 
…onnector

- Iroha connector is broken for some time and it's SDK does't seem to be
    actively supported anymore (in regards of bug or security fixes).

Closes: hyperledger-cacti#3159
Part of: hyperledger-cacti#3155

Signed-off-by: Michal Bajer <[email protected]>
@petermetz petermetz enabled auto-merge (rebase) April 1, 2024 21:58
@petermetz petermetz merged commit fa27fde into hyperledger-cacti:main Apr 1, 2024
124 of 142 checks passed
@outSH outSH mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagpreetsinghsasan jagpreetsinghsasan jagpreetsinghsasan left review comments

@petermetz petermetz petermetz approved these changes

@izuru0 izuru0 izuru0 approved these changes

@takeutak takeutak Awaiting requested review from takeutak

@VRamakrishna VRamakrishna Awaiting requested review from VRamakrishna VRamakrishna is a code owner

@sandeepnRES sandeepnRES Awaiting requested review from sandeepnRES sandeepnRES is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(cactus-plugin-ledger-connector-iroha): remove deprecated iroha connector
4 participants
@outSH @petermetz @jagpreetsinghsasan @izuru0