Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(go-ethereum-socketio): remove deprecated connector #3341

Merged

Conversation

outSH
Copy link
Contributor

@outSH outSH commented Jun 20, 2024

  • Remove cactus-plugin-ledger-connector-go-ethereum-socketio connector and any reference to it.
  • Remove SocketIOApiClient from cactus-api-client since it is the last connector that was linked to it.
  • Remove legacy-socketio option from cactus-verifier-client.

Part of #3155

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Remove `cactus-plugin-ledger-connector-go-ethereum-socketio` connector and
  any reference to it.
- Remove `SocketIOApiClient` from `cactus-api-client` since it is the
  last connector that was linked to it.
- Remove `legacy-socketio` option from `cactus-verifier-client`.

Part of hyperledger-cacti#3155

Signed-off-by: Michal Bajer <[email protected]>
@outSH outSH force-pushed the remove_eth_socketio_connector_pr branch from c35e314 to 6cb6fa1 Compare August 6, 2024 10:50
@outSH outSH enabled auto-merge (rebase) August 6, 2024 10:50
@outSH outSH merged commit 56dd9f8 into hyperledger-cacti:main Aug 6, 2024
142 of 143 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants