test(test-plugin-ledger-connector-besu): jestify v21-sign-transaction-endpoint #3576
+150
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldousalvarez
requested review from
petermetz,
jagpreetsinghsasan,
VRamakrishna and
outSH
as code owners
aldousalvarez
force-pushed
the
aldousalvarez/issue3565
branch
2 times, most recently
from
223b741
to
1b42cb7
Compare
|
PR-Commit Parity is failing to a known bug: #3557 (This workflow result can be skipped for evaluating PR for merge) |
aldousalvarez
changed the title
aldousalvarez
force-pushed
the
aldousalvarez/issue3565
branch
from
1b42cb7
to
e746fe1
Compare
outSH
requested changes
Oct 8, 2024
.../src/test/typescript/integration/plugin-validator-besu/v21-sign-transaction-endpoint.test.ts
Outdated
Show resolved
Hide resolved
.../src/test/typescript/integration/plugin-validator-besu/v21-sign-transaction-endpoint.test.ts
Outdated
Show resolved
Hide resolved
aldousalvarez
force-pushed
the
aldousalvarez/issue3565
branch
from
e746fe1
to
befd829
Compare
|
@outSH re-requested for review, already done with your requested changes. Thank you |
petermetz
approved these changes
Oct 18, 2024
petermetz
force-pushed
the
aldousalvarez/issue3565
branch
from
befd829
to
381798d
Compare
petermetz
force-pushed
the
aldousalvarez/issue3565
branch
from
381798d
to
f7cae77
Compare
petermetz
requested changes
Oct 18, 2024
…-endpoint Primary Changes ---------------- packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/ integration/plugin-validator-besu/v21-sign-transaction-endpoint.test.ts Fixes hyperledger-cacti#3565 Signed-off-by: aldousalvarez <[email protected]>
aldousalvarez
force-pushed
the
aldousalvarez/issue3565
branch
from
f7cae77
to
a20b7f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit to be reviewed
test(test-plugin-ledger-connector-besu): jestify v21-sign-transaction-endpoint
Fixes #3565
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.