refactor!: move transaction error out of block payload #5118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mversic
requested review from
s8sato,
SamHSmith,
outoftardis,
Erigara,
0x009922,
DCNick3 and
dima74
as code owners
mversic
force-pushed
the
move_tx_error
branch
4 times, most recently
from
9c9186e
to
c3fcacc
Compare
mversic
force-pushed
the
move_tx_error
branch
5 times, most recently
from
a95d78d
to
0a7a0c4
Compare
mversic
force-pushed
the
move_tx_error
branch
3 times, most recently
from
0b03730
to
b93c621
Compare
mversic
force-pushed
the
move_tx_error
branch
2 times, most recently
from
84685b4
to
e768e22
Compare
mversic
force-pushed
the
move_tx_error
branch
from
e768e22
to
d1770e7
Compare
mversic
force-pushed
the
move_tx_error
branch
2 times, most recently
from
4292ede
to
b4141d1
Compare
dima74
reviewed
Oct 16, 2024
mversic
force-pushed
the
move_tx_error
branch
from
b4141d1
to
67529b0
Compare
dima74
previously approved these changes
Oct 17, 2024
mversic
force-pushed
the
move_tx_error
branch
from
67529b0
to
c60f9de
Compare
mversic
force-pushed
the
move_tx_error
branch
3 times, most recently
from
88f108d
to
de63dec
Compare
s8sato
previously approved these changes
Oct 23, 2024
dima74
previously approved these changes
Oct 23, 2024
Signed-off-by: Marin Veršić <[email protected]>
mversic
force-pushed
the
move_tx_error
branch
from
de63dec
to
2e248a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5001
Context
since transaction error is not part of the block hash or protected by the block signature it's better to move it outside of block payload to avoid confusion. The main reason is that we don't want a change in transaction error that happens after block creation to affect block header
I didn't go that far in this PR, but I think it might be ok to keep this information in the
stateinstead of inside a block. This could be explored in future workFuture work
even though error will no longer be a part of the block header it can still be protected with block signatures. We will just do this explicitly. This is to be handled in #5144