-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: restore unstable network tests #5197
base: main
Are you sure you want to change the base?
test: restore unstable network tests #5197
Conversation
Signed-off-by: 0x009922 <[email protected]>
Signed-off-by: 0x009922 <[email protected]>
Signed-off-by: 0x009922 <[email protected]>
Signed-off-by: 0x009922 <[email protected]>
d627cf7
to
1c5fe2b
Compare
Relay somewhat works, but weird network behaviour continues happening. Specifically:
|
I think it's good enough to merge. Then we'll have to backtrack and compare to last known working iroha build |
I have some doubts that there might be something wrong with the relay. Anyway, let me rehearse the code and I will undraft it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about renaming "faulty peers" to "fault tolerance", which sounds to me like a clearer expression of what this test should guarantee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me.
Context
Close #5153
Solution
Implement a TCP relay as described in #5164 (comment). This allows to suspend packages being sent to and from specific peers.
Checklist
CONTRIBUTING.md
.