Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: restore unstable network tests #5197

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

0x009922
Copy link
Contributor

Context

Close #5153

Solution

Implement a TCP relay as described in #5164 (comment). This allows to suspend packages being sent to and from specific peers.

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

@0x009922 0x009922 added the Tests label Oct 29, 2024
@0x009922 0x009922 self-assigned this Oct 29, 2024
@0x009922 0x009922 marked this pull request as draft October 29, 2024 08:12
@0x009922 0x009922 changed the title test: restory unstable network peers test: restore unstable network peers Oct 29, 2024
@0x009922 0x009922 changed the title test: restore unstable network peers test: restore unstable network tests Oct 29, 2024
@0x009922
Copy link
Contributor Author

0x009922 commented Nov 5, 2024

Relay somewhat works, but weird network behaviour continues happening. Specifically:

  • "Suspended" peers still find way to broadcast transactions?
  • Network synchronizes for a long time for no clear reason
  • Flaky. Sync sometimes doesn't happen. Not sure if something is wrong with the relay or with Iroha itself

@mversic
Copy link
Contributor

mversic commented Nov 5, 2024

Relay somewhat works, but weird network behaviour continues happening. Specifically:

  • "Suspended" peers still find way to broadcast transactions?
  • Network synchronizes for a long time for no clear reason
  • Flaky. Sync sometimes doesn't happen. Not sure if something is wrong with the relay or with Iroha itself

I think it's good enough to merge. Then we'll have to backtrack and compare to last known working iroha build

@0x009922
Copy link
Contributor Author

0x009922 commented Nov 5, 2024

I think it's good enough to merge. Then we'll have to backtrack and compare to last known working iroha build

I have some doubts that there might be something wrong with the relay.

Anyway, let me rehearse the code and I will undraft it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about renaming "faulty peers" to "fault tolerance", which sounds to me like a clearer expression of what this test should guarantee

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-implement integration tests with faulty peers
3 participants