Update amd64 Dockerfile from alpine-based to ubuntu-based #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jt-nti
reviewed
May 9, 2023
There was a problem hiding this comment.
Hi @satota2, thank you for the pull request! There are a couple of minor issues where the architecture is hard coded to amd64 now that the Fabric images are multi architecture. I'm happy to merge the current changes as-is and update to use $(dpkg --print-architecture) for the go and yq downloads in a follow on PR, or it would be great if you're happy to update this PR. Let me know which you would prefer. Thanks again!
From 2.5.0, Fabric switches base docker images from golang-alpine to ubuntu 20. This patch follows this update. Signed-off-by: Tatsuya Sato <[email protected]>
satota2
force-pushed
the
ubuntu-based-docker-image
branch
from
f3d222b
to
51e1ca6
Compare
|
@jt-nti Thank you for your reviews! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From 2.5.0, Fabric switches base docker images from golang-alpine to ubuntu 20.
This patch follows this update.
Resolves #91