Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Dind References From CodeBase #172

Merged
merged 10 commits into from
Mar 21, 2024
1 change: 0 additions & 1 deletion api/v1beta1/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ const (
ORDERER Component = "ORDERER"
PEER Component = "PEER"
GRPCPROXY Component = "GRPCPROXY"
DIND Component = "DIND"
COUCHDB Component = "COUCHDB"
CCLAUNCHER Component = "CCLAUNCHER"
ENROLLER Component = "ENROLLER"
Expand Down
6 changes: 0 additions & 6 deletions api/v1beta1/ibppeer.go
Original file line number Diff line number Diff line change
Expand Up @@ -211,10 +211,6 @@ func (s *IBPPeer) GetResource(comp Component) corev1.ResourceRequirements {
if s.Spec.Resources.GRPCProxy != nil {
return *s.Spec.Resources.GRPCProxy
}
case DIND:
if s.Spec.Resources.DinD != nil {
return *s.Spec.Resources.DinD
}
case COUCHDB:
if s.Spec.Resources.CouchDB != nil {
return *s.Spec.Resources.CouchDB
Expand Down Expand Up @@ -307,7 +303,6 @@ func (i *PeerImages) Override(requested *PeerImages, registryURL string, arch st
i.PeerInitImage = image.GetImage(registryURL, i.PeerInitImage, requested.PeerInitImage)
i.PeerImage = image.GetImage(registryURL, i.PeerImage, requested.PeerImage)
i.CouchDBImage = image.GetImage(registryURL, i.CouchDBImage, requested.CouchDBImage)
i.DindImage = image.GetImage(registryURL, i.DindImage, requested.DindImage)
i.GRPCWebImage = image.GetImage(registryURL, i.GRPCWebImage, requested.GRPCWebImage)
i.CCLauncherImage = image.GetImage(registryURL, i.CCLauncherImage, requested.CCLauncherImage)
i.FileTransferImage = image.GetImage(registryURL, i.FileTransferImage, requested.FileTransferImage)
Expand All @@ -322,7 +317,6 @@ func (i *PeerImages) Override(requested *PeerImages, registryURL string, arch st
i.PeerInitTag = image.GetTag(arch, i.PeerInitTag, requested.PeerInitTag)
i.PeerTag = image.GetTag(arch, i.PeerTag, requested.PeerTag)
i.CouchDBTag = image.GetTag(arch, i.CouchDBTag, requested.CouchDBTag)
i.DindTag = image.GetTag(arch, i.DindTag, requested.DindTag)
i.GRPCWebTag = image.GetTag(arch, i.GRPCWebTag, requested.GRPCWebTag)
i.CCLauncherTag = image.GetTag(arch, i.CCLauncherTag, requested.CCLauncherTag)
i.FileTransferTag = image.GetTag(arch, i.FileTransferTag, requested.FileTransferTag)
Expand Down
17 changes: 0 additions & 17 deletions api/v1beta1/ibppeer_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -136,11 +136,6 @@ type IBPPeerSpec struct {
// +operator-sdk:gen-csv:customresourcedefinitions.specDescriptors=true
Zone string `json:"zone,omitempty"`

/* advanced configs */
// DindArgs (Optional) is used to override args passed to dind container
// +operator-sdk:gen-csv:customresourcedefinitions.specDescriptors=true
DindArgs []string `json:"dindArgs,omitempty"`

// Action (Optional) is object for peer actions
// +operator-sdk:gen-csv:customresourcedefinitions.specDescriptors=true
Action PeerAction `json:"action,omitempty"`
Expand Down Expand Up @@ -221,10 +216,6 @@ type PeerResources struct {
// +operator-sdk:gen-csv:customresourcedefinitions.specDescriptors=true
GRPCProxy *corev1.ResourceRequirements `json:"proxy,omitempty"`

// DinD (Optional) is the resources provided to the dind container
// +operator-sdk:gen-csv:customresourcedefinitions.specDescriptors=true
DinD *corev1.ResourceRequirements `json:"dind,omitempty"`

// CouchDB (Optional) is the resources provided to the couchdb container
// +operator-sdk:gen-csv:customresourcedefinitions.specDescriptors=true
CouchDB *corev1.ResourceRequirements `json:"couchdb,omitempty"`
Expand Down Expand Up @@ -274,14 +265,6 @@ type PeerImages struct {
// +operator-sdk:gen-csv:customresourcedefinitions.specDescriptors=true
PeerTag string `json:"peerTag,omitempty"`

// DindImage is the name of the dind image
// +operator-sdk:gen-csv:customresourcedefinitions.specDescriptors=true
DindImage string `json:"dindImage,omitempty"`

// DindTag is the tag of the dind image
// +operator-sdk:gen-csv:customresourcedefinitions.specDescriptors=true
DindTag string `json:"dindTag,omitempty"`

// GRPCWebImage is the name of the grpc web proxy image
// +operator-sdk:gen-csv:customresourcedefinitions.specDescriptors=true
GRPCWebImage string `json:"grpcwebImage,omitempty"`
Expand Down
10 changes: 0 additions & 10 deletions api/v1beta1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -613,12 +613,6 @@ spec:
- description: CouchDBTag is the tag of the couchdb image
displayName: Couch DBTag
path: versions.peer.image.couchdbTag
- description: DindImage is the name of the dind image
displayName: Dind Image
path: versions.peer.image.dindImage
- description: DindTag is the tag of the dind image
displayName: Dind Tag
path: versions.peer.image.dindTag
- description: EnrollerImage is the name of the init image for crypto generation
displayName: Enroller Image
path: versions.peer.image.enrollerImage
Expand Down Expand Up @@ -1305,10 +1299,6 @@ spec:
- description: StateDB is the pvc to be used as statedb's storage
displayName: State DB
path: customNames.pvc.statedb
- description: advanced configs DindArgs (Optional) is used to override args
passed to dind container
displayName: Dind Args
path: dindArgs
- description: DisableNodeOU (Optional) is used to switch nodeou on and off
displayName: Disable Node OU
path: disablenodeou
Expand Down Expand Up @@ -1347,12 +1337,6 @@ spec:
- description: CouchDBTag is the tag of the couchdb image
displayName: Couch DBTag
path: images.couchdbTag
- description: DindImage is the name of the dind image
displayName: Dind Image
path: images.dindImage
- description: DindTag is the tag of the dind image
displayName: Dind Tag
path: images.dindTag
- description: EnrollerImage is the name of the init image for crypto generation
displayName: Enroller Image
path: images.enrollerImage
Expand Down Expand Up @@ -1470,11 +1454,6 @@ spec:
path: resources.couchdb
x-descriptors:
- urn:alm:descriptor:com.tectonic.ui:resourceRequirements
- description: DinD (Optional) is the resources provided to the dind container
displayName: Din D
path: resources.dind
x-descriptors:
- urn:alm:descriptor:com.tectonic.ui:resourceRequirements
- description: Enroller (Optional) is the resources provided to the enroller
container
displayName: Enroller
Expand Down
6 changes: 0 additions & 6 deletions bundle/manifests/ibp.com_ibpconsoles.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -635,12 +635,6 @@ spec:
couchdbTag:
description: CouchDBTag is the tag of the couchdb image
type: string
dindImage:
description: DindImage is the name of the dind image
type: string
dindTag:
description: DindTag is the tag of the dind image
type: string
enrollerImage:
description: EnrollerImage is the name of the init image
for crypto generation
Expand Down
39 changes: 0 additions & 39 deletions bundle/manifests/ibp.com_ibppeers.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,6 @@ spec:
type: string
type: object
type: object
dindArgs:
description: advanced configs DindArgs (Optional) is used to override
args passed to dind container
items:
type: string
type: array
disablenodeou:
description: DisableNodeOU (Optional) is used to switch nodeou on
and off
Expand Down Expand Up @@ -162,12 +156,6 @@ spec:
couchdbTag:
description: CouchDBTag is the tag of the couchdb image
type: string
dindImage:
description: DindImage is the name of the dind image
type: string
dindTag:
description: DindTag is the tag of the dind image
type: string
enrollerImage:
description: EnrollerImage is the name of the init image for crypto
generation
Expand Down Expand Up @@ -333,33 +321,6 @@ spec:
to an implementation-defined value. More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/'
type: object
type: object
dind:
description: DinD (Optional) is the resources provided to the
dind container
properties:
limits:
additionalProperties:
anyOf:
- type: integer
- type: string
pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
x-kubernetes-int-or-string: true
description: 'Limits describes the maximum amount of compute
resources allowed. More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/'
type: object
requests:
additionalProperties:
anyOf:
- type: integer
- type: string
pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
x-kubernetes-int-or-string: true
description: 'Requests describes the minimum amount of compute
resources required. If Requests is omitted for a container,
it defaults to Limits if that is explicitly specified, otherwise
to an implementation-defined value. More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/'
type: object
type: object
enroller:
description: Enroller (Optional) is the resources provided to
the enroller container
Expand Down
6 changes: 0 additions & 6 deletions config/crd/bases/ibp.com_ibpconsoles.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -636,12 +636,6 @@ spec:
couchdbTag:
description: CouchDBTag is the tag of the couchdb image
type: string
dindImage:
description: DindImage is the name of the dind image
type: string
dindTag:
description: DindTag is the tag of the dind image
type: string
enrollerImage:
description: EnrollerImage is the name of the init image
for crypto generation
Expand Down
39 changes: 0 additions & 39 deletions config/crd/bases/ibp.com_ibppeers.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,6 @@ spec:
type: string
type: object
type: object
dindArgs:
description: advanced configs DindArgs (Optional) is used to override
args passed to dind container
items:
type: string
type: array
disablenodeou:
description: DisableNodeOU (Optional) is used to switch nodeou on
and off
Expand Down Expand Up @@ -163,12 +157,6 @@ spec:
couchdbTag:
description: CouchDBTag is the tag of the couchdb image
type: string
dindImage:
description: DindImage is the name of the dind image
type: string
dindTag:
description: DindTag is the tag of the dind image
type: string
enrollerImage:
description: EnrollerImage is the name of the init image for crypto
generation
Expand Down Expand Up @@ -334,33 +322,6 @@ spec:
to an implementation-defined value. More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/'
type: object
type: object
dind:
description: DinD (Optional) is the resources provided to the
dind container
properties:
limits:
additionalProperties:
anyOf:
- type: integer
- type: string
pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
x-kubernetes-int-or-string: true
description: 'Limits describes the maximum amount of compute
resources allowed. More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/'
type: object
requests:
additionalProperties:
anyOf:
- type: integer
- type: string
pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
x-kubernetes-int-or-string: true
description: 'Requests describes the minimum amount of compute
resources required. If Requests is omitted for a container,
it defaults to Limits if that is explicitly specified, otherwise
to an implementation-defined value. More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/'
type: object
type: object
enroller:
description: Enroller (Optional) is the resources provided to
the enroller container
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -613,12 +613,6 @@ spec:
- description: CouchDBTag is the tag of the couchdb image
displayName: Couch DBTag
path: versions.peer.image.couchdbTag
- description: DindImage is the name of the dind image
displayName: Dind Image
path: versions.peer.image.dindImage
- description: DindTag is the tag of the dind image
displayName: Dind Tag
path: versions.peer.image.dindTag
- description: EnrollerImage is the name of the init image for crypto generation
displayName: Enroller Image
path: versions.peer.image.enrollerImage
Expand Down Expand Up @@ -1305,10 +1299,6 @@ spec:
- description: StateDB is the pvc to be used as statedb's storage
displayName: State DB
path: customNames.pvc.statedb
- description: advanced configs DindArgs (Optional) is used to override args
passed to dind container
displayName: Dind Args
path: dindArgs
- description: DisableNodeOU (Optional) is used to switch nodeou on and off
displayName: Disable Node OU
path: disablenodeou
Expand Down Expand Up @@ -1347,12 +1337,6 @@ spec:
- description: CouchDBTag is the tag of the couchdb image
displayName: Couch DBTag
path: images.couchdbTag
- description: DindImage is the name of the dind image
displayName: Dind Image
path: images.dindImage
- description: DindTag is the tag of the dind image
displayName: Dind Tag
path: images.dindTag
- description: EnrollerImage is the name of the init image for crypto generation
displayName: Enroller Image
path: images.enrollerImage
Expand Down Expand Up @@ -1470,11 +1454,6 @@ spec:
path: resources.couchdb
x-descriptors:
- urn:alm:descriptor:com.tectonic.ui:resourceRequirements
- description: DinD (Optional) is the resources provided to the dind container
displayName: Din D
path: resources.dind
x-descriptors:
- urn:alm:descriptor:com.tectonic.ui:resourceRequirements
- description: Enroller (Optional) is the resources provided to the enroller
container
displayName: Enroller
Expand Down
7 changes: 3 additions & 4 deletions controllers/ibpca/mocks/careconcile.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions controllers/ibpconsole/mocks/consolereconcile.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading