Fabric Interop Node SDK Support for HTLC-based Asset Exchanges #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code and partial unit test to trigger asset locking. Signed-off-by: VRamakrishna <[email protected]>
Also refactored code and added a new signing certificate. Signed-off-by: VRamakrishna <[email protected]>
Signed-off-by: VRamakrishna <[email protected]>
Signed-off-by: VRamakrishna <[email protected]>
…asset lock protobuf changes Signed-off-by: VRamakrishna <[email protected]>
ermyas
reviewed
May 8, 2021
ermyas
reviewed
May 8, 2021
ermyas
reviewed
May 11, 2021
…c Interop SDK Signed-off-by: VRamakrishna <[email protected]>
…Node SDK Throwing an error if lock expiration time is invalid. Signed-off-by: VRamakrishna <[email protected]>
Signed-off-by: VRamakrishna <[email protected]>
Changed 'log.Info(fmt.Sprintf(...))' to 'log.Infof(...)'. Removed unnecessary 'uint64' casts. Added placeholder functions to refactor error reporting code (TODO: actual refactoring). Signed-off-by: VRamakrishna <[email protected]>
Also updated the common asset locking protobuf. Signed-off-by: VRamakrishna <[email protected]>
Signed-off-by: VRamakrishna <[email protected]>
Signed-off-by: VRamakrishna <[email protected]>
Signed-off-by: VRamakrishna <[email protected]>
Signed-off-by: VRamakrishna <[email protected]>
Signed-off-by: VRamakrishna <[email protected]>
ermyas
reviewed
May 18, 2021
core/network/fabric-interop-cc/contracts/interop/manage_assets.go
Outdated
Show resolved
Hide resolved
core/network/fabric-interop-cc/interfaces/asset-mgmt/asset_locks_contract.go
Show resolved
Hide resolved
sandeepnRES
approved these changes
May 18, 2021
Added qualifications about events exposed in Fabric Interop Node SDK. Updated code to log and return error objects in Fabric asset management CC. (TODO: refactor chaincodes to use the above pattern.) Signed-off-by: VRamakrishna <[email protected]>
…class Signed-off-by: VRamakrishna <[email protected]>
Signed-off-by: VRamakrishna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.