Skip to content

Commit

Permalink
Merge pull request #297 from hyperledger-labs/update-appbase-inheritance
Browse files Browse the repository at this point in the history
update AppBase inheritance

Signed-off-by: Jun Kimura <[email protected]>
  • Loading branch information
bluele authored Sep 3, 2024
2 parents cd49bc0 + 8d15fcb commit 738ce6c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion contracts/apps/commons/IBCAppBase.sol
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {Packet} from "../../core/04-channel/IIBCChannel.sol";
import {IIBCModule} from "../../core/26-router/IIBCModule.sol";
import {IIBCModuleErrors} from "../../core/26-router/IIBCModuleErrors.sol";

abstract contract AppBase is IERC165, Context, IIBCModuleErrors {
abstract contract AppBase is Context, IERC165, IIBCModuleErrors {
/**
* @dev Throws if called by any account other than the IBC contract.
*/
Expand Down
5 changes: 3 additions & 2 deletions contracts/core/04-channel/IBCChannelPacketSendRecv.sol
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,9 @@ contract IBCChannelPacketSendRecv is
ChannelStorage storage channelStorage =
getChannelStorage()[msg_.packet.destinationPort][msg_.packet.destinationChannel];
Channel.Data storage channel = channelStorage.channel;
if (channel.state == Channel.State.STATE_OPEN) {}
else if (channel.state == Channel.State.STATE_FLUSHING || channel.state == Channel.State.STATE_FLUSHCOMPLETE) {
if (channel.state == Channel.State.STATE_OPEN) {} else if (
channel.state == Channel.State.STATE_FLUSHING || channel.state == Channel.State.STATE_FLUSHCOMPLETE
) {
RecvStartSequence storage rseq = channelStorage.recvStartSequence;
// prevSequence=0 means the channel is not in the process of being upgraded or counterparty has not been upgraded yet
if (rseq.prevSequence != 0) {
Expand Down

0 comments on commit 738ce6c

Please sign in to comment.