Support for Swift wrapper #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: conanoc <[email protected]>
Signed-off-by: conanoc <[email protected]>
Closed
|
Maybe we should just publish the xcframework as a zip and the Android libraries as a separate .tar.gz? |
Sounds good. @blu3beri What do you think? |
|
I think I need to test uniffi first because uniffi will generate a different header file. I'll close this now and re-open it later if uniffi fails. |
We need the ios and android build to be published in one tar/zip so they can be dynamically downloaded when the react native package is installed from npm. We can't download multiple binaries, or we'd have to implement that logic ourselves |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #99, which is necessary for Swift.
The xcframework built for reactive-native can be shared with the Swift wrapper. But, it requires a different archive format. So I added a workflow step to archive it using
zipwith a different folder nameAskarFramework.The Swift wrapper in different repo could download the zipped xcframework for its dependencies.