chore: update minSdkVersion to get the project version or fallback to 21 #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ja-bravo
force-pushed
the
chore/min-sdk-version
branch
from
9054768
to
f94ca2c
Compare
TimoGlastra
approved these changes
May 9, 2024
There was a problem hiding this comment.
This looks good to me.
@berendsliedrecht could you also take a look?
berendsliedrecht
approved these changes
May 10, 2024
Signed-off-by: Jose Bravo <[email protected]>
ja-bravo
force-pushed
the
chore/min-sdk-version
branch
from
f94ca2c
to
183c342
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the react-native wrapper to get the
minSdkVersionfrom the project config or fallback to the current hardcoded version.I'm not entirely sure if anything else is needed but with this change I could get an app running on React Native 0.74. This change would also be needed in othe repos (
@hyperledger/anoncreds-react-nativeand@hyperledger/indy-vdr-react-nativeat least) but I'd like to get approval here before spamming the other repos 😄