Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support IPC transport for JSON-RPC APIs #535

Closed
timbeiko opened this issue Mar 20, 2020 · 3 comments · Fixed by #3695
Closed

Support IPC transport for JSON-RPC APIs #535

timbeiko opened this issue Mar 20, 2020 · 3 comments · Fixed by #3695
Assignees
@diega
Labels
help wanted Extra attention is needed

Comments

@timbeiko
Copy link
Contributor

So that system administrators can expose JSON-RPC APIs exclusively to localhost without needing firewalls, add a IPC transport for the JSON-RPC APIs.

This would make things better for Vipnode: [https://github.com/vipnode/vipnode/issues/37#issuecomment-505197281]

Acceptance Criteria

  • IPC can be enabled or disabled independently of JSON-RPC

  • Supported API groups (admin, eth, net etc) can be specified separately for IPC and HTTP endpoints

  • IPC implementation is compatible with Web3J IPC implementation

  • IPC implementation is compatible with geth attach
@timbeiko timbeiko added the help wanted Extra attention is needed label Mar 20, 2020
@mFarghaly
Copy link

any updates on this?
it will make it easy to query nodes without exposing HTTP endpoints.

@timbeiko
Copy link
Contributor Author

@RatanRSur @abdelhamidbakhta @matkt see comment above

@atoulme atoulme reopened this Aug 20, 2021
@atoulme
Copy link
Contributor

atoulme commented Aug 20, 2021

This need is still present, reopening.

@diega diega self-assigned this Mar 23, 2022
diega added a commit to diega/besu that referenced this issue Apr 5, 2022
@diega
Extract json-rpc HTTP authentication to a handler [hyperledger#535]
8c2fe3e 
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 5, 2022
@diega
Move authentication json-rpc HTTP handler first in the execution pipe…
17ebea1 
…line [hyperledger#535]

Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 5, 2022
@diega
Replace TimeoutHandler in GraphQLHttpService with Vert.x's impl [hype…
70a28a3 
…rledger#535]

Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 5, 2022
@diega
Extract json-rpc HTTP parser to a handler [hyperledger#535]
29cdbd3 
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 5, 2022
@diega
Refactor json-rpc HTTP handler [hyperledger#535]
cc78c30 
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 5, 2022
@diega
Refactor json-rpc WS handler [hyperledger#535]
c195461 
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 5, 2022
@diega
Add json-rpc IPC support [hyperledger#535]
a26ea45 
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 5, 2022
@diega
Add json-rpc IPC support [hyperledger#535]
ff06725 
Signed-off-by: Diego López León <[email protected]>
@diega diega mentioned this issue Apr 5, 2022
Merged
2 tasks
diega added a commit to diega/besu that referenced this issue Apr 6, 2022
@diega
Add json-rpc IPC support [hyperledger#535]
a471af5 
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 6, 2022
@diega
Refactor json-rpc HTTP handler [hyperledger#535]
3e87a3c 
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 6, 2022
@diega
Refactor json-rpc WS handler [hyperledger#535]
dce0cf8 
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 6, 2022
@diega
Add json-rpc IPC support [hyperledger#535]
25c56f2 
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 7, 2022
@diega
Fix json-rpc HTTP tests [hyperledger#535]
5a0f029 
The `o.h.b.e.a.j.JsonRpcHttpServiceTest#exceptionallyHandleJsonSingleRequest` and `o.h.b.e.a.j.JsonRpcHttpServiceTest#exceptionallyHandleJsonBatchRequest` tests were throwing ClassCastException in `o.h.b.e.a.j.JsonRpcHttpService#validateMethodAvailability` which wasn't ever catched, returning status 500 by default, but that wasn't the use case aimed to test. Another test running an exceptional method is `o.h.b.t.a.p.EnclaveErrorAcceptanceTest#whenEnclaveIsDisconnectedGetReceiptReturnsInternalError` which validates an "Internal Error" proper json-rpc response. I changed the first two tests to be consistent with the later one.

Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 7, 2022
@diega
Extract json-rpc HTTP authentication to a handler [hyperledger#535]
51edd71 
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 7, 2022
@diega
Move authentication json-rpc HTTP handler first in the execution pipe…
3f17146 
…line [hyperledger#535]

Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 7, 2022
@diega
Replace TimeoutHandler in GraphQLHttpService with Vert.x's impl [hype…
31f2795 
…rledger#535]

Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 7, 2022
@diega
Extract json-rpc HTTP parser to a handler [hyperledger#535]
d103872 
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 7, 2022
@diega
Refactor json-rpc HTTP handler [hyperledger#535]
95dc6fb 
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 7, 2022
@diega
Refactor json-rpc WS handler [hyperledger#535]
20d99c0 
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 7, 2022
@diega
Add json-rpc IPC support [hyperledger#535]
b484456 
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 7, 2022
@diega
Fix json-rpc HTTP tests [hyperledger#535]
81ae2a3 
The `o.h.b.e.a.j.JsonRpcHttpServiceTest#exceptionallyHandleJsonSingleRequest` and `o.h.b.e.a.j.JsonRpcHttpServiceTest#exceptionallyHandleJsonBatchRequest` tests were throwing ClassCastException in `o.h.b.e.a.j.JsonRpcHttpService#validateMethodAvailability` which wasn't ever catched, returning status 500 by default, but that wasn't the use case aimed to test. Another test running an exceptional method is `o.h.b.t.a.p.EnclaveErrorAcceptanceTest#whenEnclaveIsDisconnectedGetReceiptReturnsInternalError` which validates an "Internal Error" proper json-rpc response. I changed the first two tests to be consistent with the later one.

Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 7, 2022
@diega
Extract json-rpc HTTP authentication to a handler [hyperledger#535]
d19dccd 
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 22, 2022
@diega
Fix json-rpc HTTP tests [hyperledger#535]
3fdcd76 
The `o.h.b.e.a.j.JsonRpcHttpServiceTest#exceptionallyHandleJsonSingleRequest` and `o.h.b.e.a.j.JsonRpcHttpServiceTest#exceptionallyHandleJsonBatchRequest` tests were throwing ClassCastException in `o.h.b.e.a.j.JsonRpcHttpService#validateMethodAvailability` which wasn't ever catched, returning status 500 by default, but that wasn't the use case aimed to test. Another test running an exceptional method is `o.h.b.t.a.p.EnclaveErrorAcceptanceTest#whenEnclaveIsDisconnectedGetReceiptReturnsInternalError` which validates an "Internal Error" proper json-rpc response. I changed the first two tests to be consistent with the later one.

Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 22, 2022
@diega
Extract json-rpc HTTP authentication to a handler [hyperledger#535]
e9a917c 
Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 22, 2022
@diega
Move authentication json-rpc HTTP handler first in the execution pipe…
cade8d3 
…line [hyperledger#535]

Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 22, 2022
@diega
Replace TimeoutHandler in GraphQLHttpService with Vert.x's impl [hype…
34e94a2 
…rledger#535]

Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 22, 2022
@diega
Extract json-rpc HTTP parser to a handler [hyperledger#535]
50eded5 
Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 22, 2022
@diega
Refactor json-rpc HTTP handler [hyperledger#535]
018310f 
Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 22, 2022
@diega
Refactor json-rpc WS handler [hyperledger#535]
d12a2b1 
Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 22, 2022
@diega
Add json-rpc IPC support [hyperledger#535]
4e07dd3 
Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 22, 2022
@diega
Add json-rpc IPC support [hyperledger#535]
a86dce0 
Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 22, 2022
@diega
Add json-rpc IPC support [hyperledger#535]
09a2622 
Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 22, 2022
@diega
Add json-rpc IPC support [hyperledger#535]
376a3c0 
Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 25, 2022
@diega
Fix json-rpc HTTP tests [hyperledger#535]
2a5ec47 
The `o.h.b.e.a.j.JsonRpcHttpServiceTest#exceptionallyHandleJsonSingleRequest` and `o.h.b.e.a.j.JsonRpcHttpServiceTest#exceptionallyHandleJsonBatchRequest` tests were throwing ClassCastException in `o.h.b.e.a.j.JsonRpcHttpService#validateMethodAvailability` which wasn't ever catched, returning status 500 by default, but that wasn't the use case aimed to test. Another test running an exceptional method is `o.h.b.t.a.p.EnclaveErrorAcceptanceTest#whenEnclaveIsDisconnectedGetReceiptReturnsInternalError` which validates an "Internal Error" proper json-rpc response. I changed the first two tests to be consistent with the later one.

Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 25, 2022
@diega
Extract json-rpc HTTP authentication to a handler [hyperledger#535]
063508a 
Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 25, 2022
@diega
Move authentication json-rpc HTTP handler first in the execution pipe…
44979b7 
…line [hyperledger#535]

Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 25, 2022
@diega
Replace TimeoutHandler in GraphQLHttpService with Vert.x's impl [hype…
dd7ef3a 
…rledger#535]

Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 25, 2022
@diega
Extract json-rpc HTTP parser to a handler [hyperledger#535]
bd0d195 
Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 25, 2022
@diega
Refactor json-rpc HTTP handler [hyperledger#535]
a22501a 
Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 25, 2022
@diega
Refactor json-rpc WS handler [hyperledger#535]
e6a56be 
Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 25, 2022
@diega
Add json-rpc IPC support [hyperledger#535]
940e08d 
Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 26, 2022
@diega
Fix json-rpc HTTP tests [hyperledger#535]
8fc185e 
The `o.h.b.e.a.j.JsonRpcHttpServiceTest#exceptionallyHandleJsonSingleRequest` and `o.h.b.e.a.j.JsonRpcHttpServiceTest#exceptionallyHandleJsonBatchRequest` tests were throwing ClassCastException in `o.h.b.e.a.j.JsonRpcHttpService#validateMethodAvailability` which wasn't ever catched, returning status 500 by default, but that wasn't the use case aimed to test. Another test running an exceptional method is `o.h.b.t.a.p.EnclaveErrorAcceptanceTest#whenEnclaveIsDisconnectedGetReceiptReturnsInternalError` which validates an "Internal Error" proper json-rpc response. I changed the first two tests to be consistent with the later one.

Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 26, 2022
@diega
Extract json-rpc HTTP authentication to a handler [hyperledger#535]
236abe4 
Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 26, 2022
@diega
Move authentication json-rpc HTTP handler first in the execution pipe…
9038a64 
…line [hyperledger#535]

Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 26, 2022
@diega
Replace TimeoutHandler in GraphQLHttpService with Vert.x's impl [hype…
933963f 
…rledger#535]

Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 26, 2022
@diega
Extract json-rpc HTTP parser to a handler [hyperledger#535]
a34f2ff 
Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 26, 2022
@diega
Refactor json-rpc HTTP handler [hyperledger#535]
7fe18c4 
Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 26, 2022
@diega
Refactor json-rpc WS handler [hyperledger#535]
e2645ba 
Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
diega added a commit to diega/besu that referenced this issue Apr 26, 2022
@diega
Add json-rpc IPC support [hyperledger#535]
70a0196 
Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
macfarla pushed a commit that referenced this issue Apr 27, 2022
@diega
Add IPC transport for JSON-RPC APIs (#3695)
2884582 
* Fix json-rpc HTTP tests [#535]

The `o.h.b.e.a.j.JsonRpcHttpServiceTest#exceptionallyHandleJsonSingleRequest` and `o.h.b.e.a.j.JsonRpcHttpServiceTest#exceptionallyHandleJsonBatchRequest` tests were throwing ClassCastException in `o.h.b.e.a.j.JsonRpcHttpService#validateMethodAvailability` which wasn't ever catched, returning status 500 by default, but that wasn't the use case aimed to test. Another test running an exceptional method is `o.h.b.t.a.p.EnclaveErrorAcceptanceTest#whenEnclaveIsDisconnectedGetReceiptReturnsInternalError` which validates an "Internal Error" proper json-rpc response. I changed the first two tests to be consistent with the later one.

* Extract json-rpc HTTP authentication to a handler [#535]

* Replace TimeoutHandler in GraphQLHttpService with Vert.x's impl [#535]

* Extract json-rpc HTTP parser to a handler [#535]

* Refactor json-rpc WS handler [#535]

* Add json-rpc IPC support [#535]

Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
eum602 pushed a commit to lacchain/besu that referenced this issue Nov 3, 2023
@diega @eum602
Add IPC transport for JSON-RPC APIs (hyperledger#3695)
7fd0b78 
* Fix json-rpc HTTP tests [hyperledger#535]

The `o.h.b.e.a.j.JsonRpcHttpServiceTest#exceptionallyHandleJsonSingleRequest` and `o.h.b.e.a.j.JsonRpcHttpServiceTest#exceptionallyHandleJsonBatchRequest` tests were throwing ClassCastException in `o.h.b.e.a.j.JsonRpcHttpService#validateMethodAvailability` which wasn't ever catched, returning status 500 by default, but that wasn't the use case aimed to test. Another test running an exceptional method is `o.h.b.t.a.p.EnclaveErrorAcceptanceTest#whenEnclaveIsDisconnectedGetReceiptReturnsInternalError` which validates an "Internal Error" proper json-rpc response. I changed the first two tests to be consistent with the later one.

* Extract json-rpc HTTP authentication to a handler [hyperledger#535]

* Replace TimeoutHandler in GraphQLHttpService with Vert.x's impl [hyperledger#535]

* Extract json-rpc HTTP parser to a handler [hyperledger#535]

* Refactor json-rpc WS handler [hyperledger#535]

* Add json-rpc IPC support [hyperledger#535]

Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diega diega

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add IPC transport for JSON-RPC APIs diega/besu
4 participants
@atoulme @diega @mFarghaly @timbeiko