Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-7251 #7254

Closed
daniellehrner opened this issue Jun 24, 2024 · 3 comments
Closed

EIP-7251 #7254

daniellehrner opened this issue Jun 24, 2024 · 3 comments
Assignees
Labels
EIP Ethereum Improvement Proposal mainnet Prague

Comments

@daniellehrner
Copy link
Contributor

EIP-7251 has added consolidation requests coming from the EL layer. Those requests are the same type as the withdrawal requests from EIP-7002.

@macfarla macfarla self-assigned this Jun 24, 2024
@non-fungible-nelson non-fungible-nelson added mainnet EIP Ethereum Improvement Proposal Prague labels Jun 24, 2024
@lucassaldanha
Copy link
Member

A new system call to the contract needs to be implemented: https://eips.ethereum.org/EIPS/eip-7251#system-call

Just a note that this system call mechanism is similar to what is used on EIP-7002. However, our current implementation in Besu is not executing the actual contract bytecode, but is "manually" manipulating the contract storage to simulate the system call. Although this achieves the same end results, it is not a good idea as if the contract changes, we need to update our code to reflect that change (instead of just relying on the updated contract code).

My suggestion is to implement the logic to perform system calls and then use the same mechanism for both EIP-7002 and EIP-7251 system calls.

In terms of implementing system call logic, I think it could be similar to what we do with the TransactionSimulator when we want to process eth_call, but with the capability of persisting contract storage changes. But I haven't worked on Besu for a long time so I would take any suggestion I make with a grain of salt.

I believe @Gabriel-Trintinalia was looking at this system call logic at some point and might have more info about it.

@macfarla
Copy link
Contributor

macfarla commented Jul 3, 2024

waiting for system call PR and the final address & bytecode for the consolidation contract

@non-fungible-nelson
Copy link
Contributor

#7263 @macfarla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EIP Ethereum Improvement Proposal mainnet Prague
Projects
None yet
Development

No branches or pull requests

5 participants