Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor EIP-7002 implementation to use contract #7259

Closed
jflo opened this issue Jun 25, 2024 · 1 comment · Fixed by #7263
Closed

Refactor EIP-7002 implementation to use contract #7259

jflo opened this issue Jun 25, 2024 · 1 comment · Fixed by #7263
Assignees

Comments

@jflo
Copy link
Contributor

jflo commented Jun 25, 2024

When EIP-7002 was designed, client teams had the option of calling an enshrined contract, or implementing it directly against state. When this was implemented, we chose the option of a direct implementation against the state. Since then, we've realized offering teams that choice opens up the potential for bugs, and when EIP-7251 is implemented it should be via the enshrined contract.

For consistency purposes, we should go back over the EIP-7002 implementation and alter it to be more consistent with future "requests" that are implemented via enshrined contracts.

Acceptance Criteria

  • EIP-7002 depends on enshrined contract.
@Gabriel-Trintinalia
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants