Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eth_getLogs issue (missing logs) #1351

Merged
merged 10 commits into from
Sep 10, 2020
Merged

Fix eth_getLogs issue (missing logs) #1351

merged 10 commits into from
Sep 10, 2020

Conversation

matkt
Copy link
Contributor

@matkt matkt commented Aug 31, 2020 •
edited
Loading

Signed-off-by: Karim TAAM [email protected]

PR description

This PR fixes some issues which caused some log to be missing when calling the eth_getLogs method

  • Setting up a cache version in data/caches/CACHE-METADATA.json
  • Add a check integrity of the cache
  • Fix a lock issue

##Tests performed

  • Sync Goerli from scratch (*4) without fix and compare all blocks with Infura
    (reproduce an issue every time)
  • Sync Goerli from scratch (*4) with the fix and compare all blocks with Infura (ok every time)
  • Sync Goerli with an old version of the cache already present (all the cache is reload to avoid some issues)

Changelog

@matkt
candidate fix for get logs caching issue
c1445ec 
Signed-off-by: Karim TAAM <[email protected]>
@matkt
remove counter
62f86cc 
Signed-off-by: Karim TAAM <[email protected]>
@matkt
fix cache versioning issue
fa674ab 
Signed-off-by: Karim TAAM <[email protected]>
@matkt
fix lock sync issues
189eee6 
Signed-off-by: Karim TAAM <[email protected]>
@matkt
clean code
c2e9c3c 
Signed-off-by: Karim TAAM <[email protected]>
@matkt
clean code
658a5ce 
update CHANGELOG.md

Signed-off-by: Karim TAAM <[email protected]>
@matkt
Merge master into feature/fix-get-logs
3e7d2f3 
Signed-off-by: Karim TAAM <[email protected]>
@matkt matkt marked this pull request as ready for review September 7, 2020 12:38
shemnon
shemnon approved these changes Sep 10, 2020
View reviewed changes
CHANGELOG.md Outdated
@@ -9,12 +9,12 @@

### Bug Fixes

* Fix logs queries missing results against chain head [\#1351](https://github.com/hyperledger/besu/pull/1351)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to a new 1.5.5 section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@matkt matkt merged commit 65bb27c into hyperledger:master Sep 10, 2020
@ajsutton ajsutton mentioned this pull request Sep 11, 2020
Closed
@matkt matkt deleted the feature/fix-get-logs branch September 29, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shemnon shemnon shemnon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matkt @shemnon