Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a spdx license check gradle task #30

Merged
merged 10 commits into from
Sep 20, 2019
Merged

Adding a spdx license check gradle task #30

merged 10 commits into from
Sep 20, 2019

Conversation

joshuafernandes
Copy link
Contributor

PR description

  • custom task to check spdx license header
  • spotless will no longer be putting in the header

Fixed Issue(s)

  • custom task to check spdx license header
  • spotless will no longer be putting in the header

@joshuafernandes
adding in spdx-license-identifier & updated check for the same; remov…
146a47b 
…ing license check from spotless

Signed-off-by: Joshua Fernandes <[email protected]>
@joshuafernandes
updating regexes
4d0b8e7 
Signed-off-by: Joshua Fernandes <[email protected]>
EdJoJob
EdJoJob approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@EdJoJob EdJoJob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked all changes other than copyright with git diff $(git merge-base master HEAD) $(git log $(git merge-base master HEAD)..HEAD --numstat | gegrep ^[[:digit:]]+ | gegrep -v ^[34]\s | gawk {print $3}) (gawk/gegrep are GNU awk/grep)
Looks good

@joshuafernandes joshuafernandes merged commit bac5c67 into hyperledger:master Sep 20, 2019
@joshuafernandes joshuafernandes deleted the add-spdx-license-id branch September 20, 2019 05:00
garyschulte pushed a commit to garyschulte/besu that referenced this pull request Jan 5, 2024
@jflo
Merge pull request hyperledger#30 from jflo/gha_artifacts
6a49cc1 
build artifacts on release draft
fab-10 added a commit to fab-10/besu that referenced this pull request Jan 10, 2024
@fab-10
Introduce TransactionSelectionContext to pass data between selectors …
c029a9f 
…and plugin (hyperledger#30)

* Introduce TransactionSelectionContext to pass data between selectors

Signed-off-by: Fabio Di Fabio <[email protected]>

* Use TransactionSelectionContext in all the methods of the plugin selector

Signed-off-by: Fabio Di Fabio <[email protected]>

---------

Signed-off-by: Fabio Di Fabio <[email protected]>
fab-10 added a commit to fab-10/besu that referenced this pull request Jan 10, 2024
@fab-10
Introduce TransactionSelectionContext to pass data between selectors …
c1def70 
…and plugin (hyperledger#30)

* Introduce TransactionSelectionContext to pass data between selectors

Signed-off-by: Fabio Di Fabio <[email protected]>

* Use TransactionSelectionContext in all the methods of the plugin selector

Signed-off-by: Fabio Di Fabio <[email protected]>

---------

Signed-off-by: Fabio Di Fabio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdJoJob EdJoJob EdJoJob approved these changes

@ajsutton ajsutton Awaiting requested review from ajsutton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuafernandes @EdJoJob @ajsutton