Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nullpointer on snapsync #3773

Merged
merged 4 commits into from
May 3, 2022
Merged

Conversation

matkt
Copy link
Contributor

@matkt matkt commented Apr 28, 2022

Signed-off-by: Karim TAAM [email protected]

PR description

Fixes a bug that caused Besu to not restart healing properly when changing pivot blocks. Snapsync thought the sync was done instead of restarting on a new pivot block.

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

Signed-off-by: Karim TAAM <[email protected]>
Signed-off-by: Karim TAAM <[email protected]>
@matkt matkt marked this pull request as ready for review April 29, 2022 13:10
@matkt matkt enabled auto-merge (squash) April 29, 2022 13:17
@sonarcloud
Copy link

sonarcloud bot commented May 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@matkt matkt merged commit beb4e3b into hyperledger:main May 3, 2022
lucassaldanha pushed a commit to lucassaldanha/besu that referenced this pull request May 4, 2022
Signed-off-by: Karim TAAM <[email protected]>
Signed-off-by: Lucas Saldanha <[email protected]>
lucassaldanha added a commit that referenced this pull request May 4, 2022
* fix nullpointer on snapsync (#3773)
* Introduce RocksDbSegmentIdentifier to avoid changing the storege plug… (#3755)
* Release 22.4.0

Signed-off-by: Lucas Saldanha <[email protected]>

Co-authored-by: matkt <[email protected]>
Co-authored-by: Fabio Di Fabio <[email protected]>
@matkt matkt deleted the fix-nullpointer-snapsync branch January 13, 2023 13:02
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants