-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop backward sync if genesis block has been reached #3869
Merged
fab-10
merged 4 commits into
hyperledger:main
from
fab-10:stop-backward-sync-at-genesis
May 20, 2022
Merged
Stop backward sync if genesis block has been reached #3869
fab-10
merged 4 commits into
hyperledger:main
from
fab-10:stop-backward-sync-at-genesis
May 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jflo
approved these changes
May 19, 2022
macfarla
reviewed
May 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test for this?
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
fab-10
force-pushed
the
stop-backward-sync-at-genesis
branch
from
May 20, 2022 12:14
f9d4f71
to
52dd817
Compare
Signed-off-by: Fabio Di Fabio <[email protected]>
Done |
Kudos, SonarCloud Quality Gate passed! |
gezero
reviewed
May 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
sharad-develop
pushed a commit
to sharad-develop/besu
that referenced
this pull request
May 27, 2022
Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Sharad Gulati <[email protected]>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Fabio Di Fabio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fabio Di Fabio [email protected]
PR description
Fixed Issue(s)
fixes #3870
Documentation
doc-change-required
label to this PR ifupdates are required.
Changelog