Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated INVALID_TERMINAL_BLOCK with INVALID lvh 0x0 #3882

Merged
merged 3 commits into from
May 23, 2022

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented May 20, 2022

Signed-off-by: Fabio Di Fabio [email protected]

PR description

Fixed Issue(s)

fixes #3881
fixes #3842

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 🚢

@fab-10 fab-10 marked this pull request as ready for review May 23, 2022 08:24
Signed-off-by: Fabio Di Fabio <[email protected]>
@fab-10 fab-10 force-pushed the deprecate_INVALID_TERMINAL_BLOCK branch from 76360df to 77871cc Compare May 23, 2022 08:32
@sonarcloud
Copy link

sonarcloud bot commented May 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@fab-10 fab-10 merged commit 5cdda94 into hyperledger:main May 23, 2022
@fab-10 fab-10 deleted the deprecate_INVALID_TERMINAL_BLOCK branch May 23, 2022 12:39
sharad-develop pushed a commit to sharad-develop/besu that referenced this pull request May 27, 2022
@fab-10 fab-10 added the mainnet label Jun 28, 2022
@ASISBusiness
Copy link

Signed-off-by: Fabio Di Fabio [email protected]

PR description

Fixed Issue(s)

fixes #3881

fixes #3842

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if

    updates are required.

Changelog

Thank you very much for the engagement business opportunity.

Kindly regards,

Juan David

eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Engine API Update: replace INVALID_TERMINAL_BLOCK with lvh=0x00..00 Remove INVALID_TERMINAL_BLOCK_HASH error
3 participants