When on PoS the head can be only be updated by ForkchoiceUpdate #3994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fab-10
force-pushed
the
newPayload_wo_changing_head
branch
from
d34b222
to
5c2fc61
Compare
fab-10
changed the title
fab-10
changed the title
fab-10
force-pushed
the
newPayload_wo_changing_head
branch
2 times, most recently
from
6785b1f
to
a939dd2
Compare
garyschulte
reviewed
Jun 20, 2022
| @@ -236,6 +237,35 @@ protected Hash calculateRootHash( | |||
| return Hash.wrap(rootHash); | |||
| } | |||
|
|
|||
| @Override | |||
| public void remember(final BlockHeader blockHeader) { | |||
| public void remember(final BlockHeader blockHeader) { | ||
| checkArgument(blockHeader != null, "Block header must not be null"); | ||
|
|
||
| final BonsaiWorldStateUpdater localUpdater = updater.copy(); |
There was a problem hiding this comment.
This should be of interest to @gezero
There was a problem hiding this comment.
The copy method will disappear, I will see this as fail of build when I will try to merge.
| @@ -34,4 +34,15 @@ public interface MutableWorldState extends WorldState, MutableWorldView { | |||
| * `null` should be passed in. | |||
| */ | |||
| void persist(BlockHeader blockHeader); | |||
|
|
|||
| /** | |||
| * Remember accumulated changes to underlying storage for future use, without making this the | |||
| updateCacheForNewCanonicalHead(block, td); | ||
| final BlockAddedEvent blockAddedEvent; | ||
| if (storeOnly) { | ||
| blockAddedEvent = handleStoreOnly(blockWithReceipts); |
There was a problem hiding this comment.
Does this mean that if/when we "rewind" to this future block in forkchoiceUpdated that we are not going to fire a an event of type HEAD_ADVANCED anymore?
There was a problem hiding this comment.
good catch! Indeed this need to be reviewed
There was a problem hiding this comment.
@garyschulte please check now, this commit
Introduce forwardToBlock
It moves head to the block sent by a previous newPayload, and triggers
the advanced head event that will also update the Bonsai world state.
fab-10
force-pushed
the
newPayload_wo_changing_head
branch
from
a939dd2
to
b02de74
Compare
…Block When executing a newPayload or build a new block, we do not need to move the chain head and update the world state, since this will be done by a following forkchoice update call, but we still need to validate the block and doing so we can also prepare everything for the future call, so we do not need to re-execute everything, but only update the pointers, so that the response to the forkchoice update call is quick. Signed-off-by: Fabio Di Fabio <[email protected]>
… nothing Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
It moves head to the block sent by a previous newPayload, and triggers the advanced head event that will also update the Bonsai world state. Signed-off-by: Fabio Di Fabio <[email protected]>
fab-10
force-pushed
the
newPayload_wo_changing_head
branch
from
b02de74
to
964d2d9
Compare
|
Thanks @garyschulte for the review, I am closing this, since it is now part of this one #4013, that contains also other changes to avoid persisting state when preparing new payloads. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing a newPayload or build a new block, we do not need to move
the chain head and update the world state, since this will be done by a
following forkchoice update call, but we still need to validate the block
and doing so we can also prepare everything for the future call, so we do
not need to re-execute everything, but only update the pointers, so that the
response to the forkchoice update call is quick.
Moreover on block proposal do only a validation of the block without storing or remembering nothing, to avoid saving data that could be stale, for example the empty block that is always proposed, is useless if another better block is produced later.
Signed-off-by: Fabio Di Fabio [email protected]
PR description
Fixed Issue(s)
fixes #3957
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog