Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enclave public key length constraint removed for private transactions #4086

Conversation

freemanzMrojo
Copy link
Contributor

@freemanzMrojo freemanzMrojo commented Jul 12, 2022

PR description

Removes the length constraint of 44 characters for the base64 version of an enclave public key for private transactions via Tessera. More details in the linked issue.

Adapts the acceptance tests so this change could be validated against the target Tessera configuration (EC encryptor).

Fixed Issue(s)

fixes #3819

freemanzMrojo and others added 30 commits May 9, 2022 15:24
Signed-off-by: Miguel Rojo <[email protected]>
Signed-off-by: Miguel Rojo <[email protected]>
Signed-off-by: Miguel Rojo <[email protected]>
@freemanzMrojo freemanzMrojo force-pushed the privacy-pubkey-length-constraint-removed branch from ad46f58 to 83fcfd5 Compare July 21, 2022 18:10
@shemnon shemnon removed their request for review July 22, 2022 16:21
@shemnon
Copy link
Contributor

shemnon commented Jul 22, 2022

I have zero exposure to the enclave code. Perhaps @macfarla @pinges could give a review?

@freemanzMrojo freemanzMrojo mentioned this pull request Jul 29, 2022
2 tasks
@macfarla macfarla merged commit 95d9626 into hyperledger:main Aug 8, 2022
codyborn pushed a commit to codyborn/besu that referenced this pull request Aug 8, 2022
…hyperledger#4086)

* removed constraint with the length of the privacy public key

* refactor to include tessera ec encryptor

* added EC snippet to the tessera json config, still need to replace base64string from web3j

* acceptance tests working after modifying the web3j library to allow secp256r1 keys

* using NACL encryptor by default

* using web3j v4.9.4 and web3j-quorum v4.9.0

Signed-off-by: Miguel Rojo <[email protected]>

Co-authored-by: Antony Denyer <[email protected]>
codyborn pushed a commit to codyborn/besu that referenced this pull request Aug 8, 2022
…hyperledger#4086)

* removed constraint with the length of the privacy public key

* refactor to include tessera ec encryptor

* added EC snippet to the tessera json config, still need to replace base64string from web3j

* acceptance tests working after modifying the web3j library to allow secp256r1 keys

* using NACL encryptor by default

* using web3j v4.9.4 and web3j-quorum v4.9.0

Signed-off-by: Miguel Rojo <[email protected]>

Co-authored-by: Antony Denyer <[email protected]>
Signed-off-by: Cody Born <[email protected]>
@freemanzMrojo freemanzMrojo deleted the privacy-pubkey-length-constraint-removed branch August 16, 2022 08:39
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
…hyperledger#4086)

* removed constraint with the length of the privacy public key

* refactor to include tessera ec encryptor

* added EC snippet to the tessera json config, still need to replace base64string from web3j

* acceptance tests working after modifying the web3j library to allow secp256r1 keys

* using NACL encryptor by default

* using web3j v4.9.4 and web3j-quorum v4.9.0

Signed-off-by: Miguel Rojo <[email protected]>

Co-authored-by: Antony Denyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove 44-byte long constraint for --privacy-public-key-file so Besu could support Tessera's EC encryptor
5 participants