-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enclave public key length constraint removed for private transactions #4086
Merged
macfarla
merged 53 commits into
hyperledger:main
from
freemanzMrojo:privacy-pubkey-length-constraint-removed
Aug 8, 2022
Merged
Enclave public key length constraint removed for private transactions #4086
macfarla
merged 53 commits into
hyperledger:main
from
freemanzMrojo:privacy-pubkey-length-constraint-removed
Aug 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Rojo <[email protected]>
Signed-off-by: Miguel Rojo <[email protected]>
Signed-off-by: Miguel Rojo <[email protected]>
Signed-off-by: Miguel Rojo <[email protected]>
…se64string from web3j Signed-off-by: Miguel Rojo <[email protected]>
…ecp256r1 keys Signed-off-by: Miguel Rojo <[email protected]>
…ecp256r1 keys Signed-off-by: Miguel Rojo <[email protected]>
…ecp256r1 keys Signed-off-by: Miguel Rojo <[email protected]>
Signed-off-by: Miguel Rojo <[email protected]>
Signed-off-by: Miguel Rojo <[email protected]>
…-removed Signed-off-by: Miguel Rojo <[email protected]>
…-removed Signed-off-by: Miguel Rojo <[email protected]>
Signed-off-by: Miguel Rojo <[email protected]>
Signed-off-by: Miguel Rojo <[email protected]>
Signed-off-by: Miguel Rojo <[email protected]>
Signed-off-by: Miguel Rojo <[email protected]>
Signed-off-by: Miguel Rojo <[email protected]>
…-removed Signed-off-by: Miguel Rojo <[email protected]>
Signed-off-by: Miguel Rojo <[email protected]>
Signed-off-by: Miguel Rojo <[email protected]>
…-removed Signed-off-by: Miguel Rojo <[email protected]>
Signed-off-by: Miguel Rojo <[email protected]>
…-removed Signed-off-by: Miguel Rojo <[email protected]>
…-removed Signed-off-by: Miguel Rojo <[email protected]>
…-removed Signed-off-by: Miguel Rojo <[email protected]>
…-removed Signed-off-by: Miguel Rojo <[email protected]>
…-removed Signed-off-by: Miguel Rojo <[email protected]>
…-removed Signed-off-by: Miguel Rojo <[email protected]>
…-removed Signed-off-by: Miguel Rojo <[email protected]>
Signed-off-by: Miguel Rojo <[email protected]>
Signed-off-by: Miguel Rojo <[email protected]>
freemanzMrojo
force-pushed
the
privacy-pubkey-length-constraint-removed
branch
from
July 21, 2022 18:10
ad46f58
to
83fcfd5
Compare
Signed-off-by: Miguel Rojo <[email protected]>
…key-length-constraint-removed Signed-off-by: Miguel Rojo <[email protected]>
Signed-off-by: Miguel Rojo <[email protected]>
Signed-off-by: Miguel Rojo <[email protected]>
antonydenyer
approved these changes
Aug 4, 2022
codyborn
pushed a commit
to codyborn/besu
that referenced
this pull request
Aug 8, 2022
…hyperledger#4086) * removed constraint with the length of the privacy public key * refactor to include tessera ec encryptor * added EC snippet to the tessera json config, still need to replace base64string from web3j * acceptance tests working after modifying the web3j library to allow secp256r1 keys * using NACL encryptor by default * using web3j v4.9.4 and web3j-quorum v4.9.0 Signed-off-by: Miguel Rojo <[email protected]> Co-authored-by: Antony Denyer <[email protected]>
codyborn
pushed a commit
to codyborn/besu
that referenced
this pull request
Aug 8, 2022
…hyperledger#4086) * removed constraint with the length of the privacy public key * refactor to include tessera ec encryptor * added EC snippet to the tessera json config, still need to replace base64string from web3j * acceptance tests working after modifying the web3j library to allow secp256r1 keys * using NACL encryptor by default * using web3j v4.9.4 and web3j-quorum v4.9.0 Signed-off-by: Miguel Rojo <[email protected]> Co-authored-by: Antony Denyer <[email protected]> Signed-off-by: Cody Born <[email protected]>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…hyperledger#4086) * removed constraint with the length of the privacy public key * refactor to include tessera ec encryptor * added EC snippet to the tessera json config, still need to replace base64string from web3j * acceptance tests working after modifying the web3j library to allow secp256r1 keys * using NACL encryptor by default * using web3j v4.9.4 and web3j-quorum v4.9.0 Signed-off-by: Miguel Rojo <[email protected]> Co-authored-by: Antony Denyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Removes the length constraint of 44 characters for the base64 version of an enclave public key for private transactions via Tessera. More details in the linked issue.
Adapts the acceptance tests so this change could be validated against the target Tessera configuration (EC encryptor).
Fixed Issue(s)
fixes #3819