Update GraphQL to be closer to execution-api spec #4112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the graphQL to be closer to the execution-api specs. This is a departure from EIP-1767 but the core devs have made it clear that the execution-apis repo is considered canonical, not the EIP. Major changes: * Add support for EIP-2930 access lists * Add support for EIP-1559 fees * Add transaction, block, receipt, and header raw rlp fields * Add chainID as base level query Some items are still fake (fee estimate, estimated tip). Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
shemnon
changed the title
macfarla
reviewed
Aug 5, 2022
There was a problem hiding this comment.
quick pass through - couple of minor comments. Is there notes or docs from ACD that we can link to as motivation for the move away from the spec?
This is a departure from EIP-1767 but the core devs have made it clear
that the execution-apis repo is considered canonical, not the EIP.
ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/graphql/GraphQLDataFetchers.java
Outdated
Show resolved
Hide resolved
...a/org/hyperledger/besu/ethereum/api/graphql/internal/pojoadapter/AccessListEntryAdapter.java
Outdated
Show resolved
Hide resolved
Unfortunately no, the best I can do is a discord thread - https://discord.com/channels/595666850260713488/746566142700814426/993575909724524584 I am disheartened that the spec and EIP process is slowly breaking down. |
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
macfarla
reviewed
Oct 5, 2022
.../api/src/test/java/org/hyperledger/besu/ethereum/api/graphql/GraphQLHttpServiceCorsTest.java
Show resolved
Hide resolved
macfarla
reviewed
Oct 5, 2022
...rces/org/hyperledger/besu/ethereum/api/graphql/eth_getBalance_invalidAccountBlockNumber.json
Show resolved
Hide resolved
Signed-off-by: Danno Ferrin <[email protected]>
shemnon
force-pushed
the
exec-api-graphql
branch
from
0f61334
to
d3a74a7
Compare
Signed-off-by: Danno Ferrin <[email protected]>
macfarla
approved these changes
Oct 5, 2022
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Oct 7, 2022
Update the graphQL to be closer to the execution-api specs. This is a departure from EIP-1767 but the core devs have made it clear that the execution-apis repo is considered canonical, not the EIP. Major changes: * Add support for EIP-2930 access lists * Add support for EIP-1559 fees * Add transaction, block, receipt, and header raw rlp fields * Add chainID as base level query Some items are still fake (fee estimate, estimated tip). Signed-off-by: Danno Ferrin <[email protected]>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Update the graphQL to be closer to the execution-api specs. This is a departure from EIP-1767 but the core devs have made it clear that the execution-apis repo is considered canonical, not the EIP. Major changes: * Add support for EIP-2930 access lists * Add support for EIP-1559 fees * Add transaction, block, receipt, and header raw rlp fields * Add chainID as base level query Some items are still fake (fee estimate, estimated tip). Signed-off-by: Danno Ferrin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Update GraphQL to be closer to execution-apis spec
Update the graphQL to be closer to the execution-api specs.
This is a departure from EIP-1767 but the core devs have made it clear
that the execution-apis repo is considered canonical, not the EIP.
Major changes:
Some items are still fake (fee estimate, effective tip).
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog