Useful response improves reputation #4130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan <[email protected]>
macfarla
approved these changes
Jul 20, 2022
| @@ -362,6 +362,14 @@ public void compareTo_withDifferentNodeId() { | |||
| assertThat(peer2.compareTo(peer1)).isEqualTo(-1); | |||
| } | |||
|
|
|||
| @Test | |||
| public void recordUsefullResponse() { | |||
fab-10
reviewed
Aug 8, 2022
There was a problem hiding this comment.
I am seeing in the logs peers with very high reputation, for example:
FullSyncTargetManager","message":"Caught up to best peer: PeerId 0xb3e02a84270c590f562e2c8b8274930c54b0a00ae001d44bd790b55c3bbc578c70738e6d4a2d32df78b6cf27a071fe54a068f3192c42ac29bd81a6663fe4fa0f, reputation PeerReputation 561, validated? true, disconnected? false, client: Geth/v1.10.21-stable-67109427/linux-amd64/go1.18.5, connection 1312721736, enode enode://b3e02a84270c590f562e2c8b8274930c54b0a00ae001d44bd790b55c3bbc578c70738e6d4a2d32df78b6cf27a071fe54a068f3192c42ac29bd81a6663fe4fa0f@34.92.61.128:29888, chain state: ChainState{estimatedHeight=7369229, bestBlock=BestBlock{totalDifficulty=0x0000000000000000000000000000000000000000000000000000000000a45b44, blockHash=0xb7c2ba396d3f4561fe619796e7ef399080823161f4b831c5b3f48445e7bf13a1, number=7369228}}. Current peers: 3","throwable":""}
since there is no cap to how much the reputation can increase.
I think make sense to have an upper bound, a peer can increase its repution until it reaches 100 again, otherwise a peer that is good for a long time, and start to be useless will take a long time before its reputation goes below
|
|
||
| @Test | ||
| public void shouldIncreaseScore() { | ||
| reputation.recordUsefulResposne(); |
2 tasks
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* useful response improves reputation Signed-off-by: Stefan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no way for peers improve their reputation. With this PR peers improve their reputation when they send a useful response.
Signed-off-by: Stefan [email protected]