Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/engine api override #4190

Merged
merged 7 commits into from
Jul 31, 2022
Merged

Feature/engine api override #4190

merged 7 commits into from
Jul 31, 2022

Commits on Jul 31, 2022

  1. initial impl of engine-api override: 

    * remove reliance on isMergeEnabled in pre-merge block header validation rules
* create a merge-specific block header validtion stack rather than leveraging mainnet
* re-add --engine-api-enabled cli param

Signed-off-by: garyschulte <[email protected]>
    @garyschulte
    garyschulte committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    3e54a11 View commit details
    Browse the repository at this point in the history

  2. revert/re-add non-basefee mergeprotocolschedule 

    Signed-off-by: garyschulte <[email protected]>
    @garyschulte
    garyschulte committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    c0faff1 View commit details
    Browse the repository at this point in the history

  3. fix toml config unit test 

    Signed-off-by: garyschulte <[email protected]>
    @garyschulte
    garyschulte committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    75fe29d View commit details
    Browse the repository at this point in the history

  4. make engine api usable without a merge config. 

    leaves the door open to supporting the engine api with other MiningCoordinators, but disables all but engine_exchangeTransitionConfiguration in the absence of mergeCoordinator

Signed-off-by: garyschulte <[email protected]>
    @garyschulte
    garyschulte committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    44b48f3 View commit details
    Browse the repository at this point in the history

  5. add engine-rpc-enabled to besucommand test in order to satisfy expect… 

    …ation

Signed-off-by: garyschulte <[email protected]>
    @garyschulte
    garyschulte committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    82fc33e View commit details
    Browse the repository at this point in the history

  6. adjust consensusContext mocks 

    Signed-off-by: garyschulte <[email protected]>
    @garyschulte
    garyschulte committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    922fc18 View commit details
    Browse the repository at this point in the history

  7. use supplier to make mergecontext optional a bit more palatable to re… 

    …ad in engine-api

Signed-off-by: garyschulte <[email protected]>
    @garyschulte
    garyschulte committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    fb31ce2 View commit details
    Browse the repository at this point in the history