Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panda print only when crossing TTD the first time #4194

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

garyschulte
Copy link
Contributor

@garyschulte garyschulte commented Jul 28, 2022

Signed-off-by: garyschulte [email protected]

PR description

ensure Pandas only print when we merge, not just when we initially set a new merge state (like on startup)

  • make panda printer static
  • add prior merge state to MergeStateHandler
  • move pandas into TransitionControllerBuilder's transition watcher
  • before we print, ensure we are PoS AND the prior merge state was pre-merge

Fixed Issue(s)

#3954

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

@garyschulte garyschulte force-pushed the bugfix/pandas-only-crossing-ttd branch from f6bc563 to c1ef70e Compare July 29, 2022 01:00
@garyschulte garyschulte marked this pull request as ready for review July 29, 2022 01:00
@garyschulte garyschulte force-pushed the bugfix/pandas-only-crossing-ttd branch from c1ef70e to 331a8d9 Compare July 29, 2022 02:17
@garyschulte garyschulte force-pushed the bugfix/pandas-only-crossing-ttd branch from 331a8d9 to a550036 Compare July 29, 2022 14:00
@jflo jflo merged commit 9b2fcde into hyperledger:main Jul 29, 2022
@garyschulte garyschulte deleted the bugfix/pandas-only-crossing-ttd branch August 3, 2022 23:18
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
* add oldState to MergeStateHandler, move Pandas to Transition watcher

Signed-off-by: garyschulte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants