Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always shutdown the mining executor on exit #4353

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Sep 7, 2022

Signed-off-by: Fabio Di Fabio [email protected]

PR description

There is an issue that prevents the PoWMiner to stop cleanly, with the effect of taking 30 seconds before the timeout expires and Besu can stop.

Basically the miner executor was only shutdown when running, but not when it was idle, this PR always shutdown the executor when the mining is stopped

Fixed Issue(s)

fixes #4313

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

@fab-10 fab-10 changed the title Always shutdown the executor Always shutdown the mining executor Sep 7, 2022
Signed-off-by: Fabio Di Fabio <[email protected]>
@fab-10 fab-10 marked this pull request as ready for review September 7, 2022 13:06
@fab-10 fab-10 changed the title Always shutdown the mining executor Always shutdown the mining executor on exit Sep 7, 2022
@fab-10 fab-10 added the mainnet label Sep 7, 2022
@fab-10 fab-10 merged commit d20f0a8 into hyperledger:main Sep 7, 2022
@fab-10 fab-10 deleted the shutdown-powminer branch September 7, 2022 14:23
garyschulte pushed a commit to garyschulte/besu that referenced this pull request Sep 7, 2022
garyschulte pushed a commit to garyschulte/besu that referenced this pull request Sep 7, 2022
garyschulte pushed a commit to garyschulte/besu that referenced this pull request Sep 7, 2022
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Besu takes too much to shutdown
2 participants