Create a new flag on RocksDB for high spec hardware to boost performance #4423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r high spec hardware to boost performance. Signed-off-by: Ameziane H <[email protected]>
…r high spec hardware to boost performance. Signed-off-by: Ameziane H <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+118
to
+122
| new DBOptions() | ||
| .setCreateIfMissing(true) | ||
| .setMaxOpenFiles(configuration.getMaxOpenFiles()) | ||
| .setDbWriteBufferSize(ROCKSDB_MEMTABLE_SIZE_HIGH_SPEC) | ||
| .setMaxBackgroundCompactions(configuration.getMaxBackgroundCompactions()) |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
Comment on lines
+130
to
+133
| new DBOptions() | ||
| .setCreateIfMissing(true) | ||
| .setMaxOpenFiles(configuration.getMaxOpenFiles()) | ||
| .setMaxBackgroundCompactions(configuration.getMaxBackgroundCompactions()) |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
…r high spec hardware to boost performance. Signed-off-by: Ameziane H <[email protected]>
jflo
approved these changes
Sep 22, 2022
|
Minimum hardware requirements to run this flag? |
|
I just update the description @milesthedisch, you must have at least 16 GiB RAM. |
Signed-off-by: garyschulte <[email protected]>
|
burned in on mainnet along with 4417 and 4425 |
2 tasks
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…nce (hyperledger#4423) * Create a new flag on RocksDB (--Xplugin-rocksdb-high-spec-enabled) for high spec hardware to boost performance. Signed-off-by: Ameziane H <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ameziane H [email protected]
PR description
Create a new flag on RocksDB (--Xplugin-rocksdb-high-spec-enabled) for high spec hardware to boost performance.
With this first version, the impact is on memory usage, as we're tuning RocksDB block cache and Memtables size. By high spec here, we mean a VM or machine with more than 16 GiB. Other modifications in future may include other resources' requirements but for now, the only requirement is on RAM.
The results are promising on a 32 GiB AWS VM, as this new flag reduces 95 percentile block processing time by 30%.
Performance improvements may appear in a couple of hours because of cache warm up time, as we can notice with RocksDB block cache hit ratio and RocksDB get time :
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog